Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds time until the next abnormality arrives progress bar to the sephirah menu, frees sephirah menu buttons #2611

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Adds time until the next abnormality arrives progress bar to the sephirah menu, frees sephirah menu buttons #2611

merged 2 commits into from
Dec 16, 2024

Conversation

Gboster-0
Copy link
Collaborator

@Gboster-0 Gboster-0 commented Dec 15, 2024 •
edited
Loading

About The Pull Request

  • Makes it so all the buttons in the sephirah console are no longer locked together, and will instead go as close as they can to their individual labels
  • Adds a progressbar showing sephirahs the time until next abnormality arrives with an accuracy of 5 seconds (i love the subsystem firing every 10 seconds)

Why It's Good For The Game

I think this is fine to add to sephirahs

How the menu now looks fully-extended:

image

How the menu looks when compacted:

image

Changelog

🆑
add: Added a progressbar telling sephirahs how long until the next abnormality arrives
/:cl:

@Gboster-0 Gboster-0 added Balance Improvements towards balance of the game. Expansion Expands upon a feature labels Dec 15, 2024
Kitsunemitsu
Kitsunemitsu approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@Kitsunemitsu Kitsunemitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a minor refresh. Approved

@Kitsunemitsu Kitsunemitsu merged commit bd0a7aa into vlggms:master Dec 16, 2024
9 checks passed
@Gboster-0 Gboster-0 deleted the Subsystem-control branch December 16, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kitsunemitsu Kitsunemitsu Kitsunemitsu approved these changes

@EgorDinamit EgorDinamit Awaiting requested review from EgorDinamit EgorDinamit is a code owner

Assignees
No one assigned
Labels
Balance Improvements towards balance of the game. Expansion Expands upon a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gboster-0 @Kitsunemitsu