Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Representative Stock Market [NOT YET] #2631

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

InsightfulParasite
Copy link
Collaborator

About The Pull Request

Requested by Kirie. Ported from TG.
Some parts of the code were changed to make it more lorefriendly to the Project Moon universe.
The defined list of all the districts is so i don't have to post that long list over and over and over.

Why It's Good For The Game

Hypothetically can be used by Representative for ahn generation.

Changelog

🆑
add: Lore defines file
add: stockexchange computer
/:cl:

@InsightfulParasite InsightfulParasite added the Feature Something new being added. label Dec 21, 2024
@Gboster-0
Copy link
Collaborator

Gboster-0 commented Dec 21, 2024

I will say, i am quite against the PR at its current state. Its code is all over the place

  • it has several procs defined globally that should not exist (look at the proper TG VOWELS define, and then at /proc/vowel()
  • It uses the non-good for(var/i = 1, i++, i>4) syntax instead of for(var/i in 1 to 4)
  • And it has un-necessary while() loops that could EASILY be for(var/i in 1 to 4)

@InsightfulParasite InsightfulParasite changed the title Tg Stock Market Console Port [DONE] Tg Stock Market Console Port [NOT YET] Dec 21, 2024
@InsightfulParasite
Copy link
Collaborator Author

I will say, i am quite against the PR at its current state. Its code is all over the place

  • it has several procs defined globally that should not exist (look at the proper TG VOWELS define, and then at /proc/vowel()
  • It uses the non-good for(var/i = 1, i++, i>4) syntax instead of for(var/i in 1 to 4)
  • And it has un-necessary while() loops that could EASILY be for(var/i in 1 to 4)

Yeah it needs to cook a bit more. Im honestly looking into porting it so i dont have to code stocks.
Ill tweak it a bit more.

@InsightfulParasite
Copy link
Collaborator Author

ughhhh im finding alot of flaws like the stocks being global and i think i have to gut and rework this entire system.

@InsightfulParasite InsightfulParasite marked this pull request as draft December 21, 2024 04:48
@InsightfulParasite InsightfulParasite changed the title Tg Stock Market Console Port [NOT YET] Representative Stock Market [NOT YET] Dec 21, 2024
@Gboster-0
Copy link
Collaborator

ughhhh im finding alot of flaws like the stocks being global and i think i have to gut and rework this entire system.

yeaaaaaaaa i think thats for the best

## About The Pull Request
Requested by Kirie. Ported from TG.
Some parts of the code were changed to make it more lorefriendly to the Project Moon universe.
The defined list of all the districts is so i dont have to post that long list over and over and over.
## Why It's Good For The Game
Hypothetically can be used by Representative for ahn generation.
## Changelog
:cl:
add: Lore defines file
add: stockexchange computer
/:cl:
@InsightfulParasite InsightfulParasite force-pushed the tg-stock-market-port branch 3 times, most recently from dbb8c9b to a508faa Compare December 21, 2024 23:47
it begins
@InsightfulParasite InsightfulParasite force-pushed the tg-stock-market-port branch 2 times, most recently from ee19b5a to e57f440 Compare December 22, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Something new being added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants