Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes round-end not auto-triggering when a player dies on combat maps because of pinocchio + R-corp round-end improvements #2667

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

Gboster-0
Copy link
Collaborator

@Gboster-0 Gboster-0 commented Jan 4, 2025

About The Pull Request

  • Makes Pinocchio no longer hold the round hostage by preventing round-end from triggering when all R-corp members die
  • Makes getting any R-corp objective at round-end make some confetti instead of giving a big red text

Why It's Good For The Game

Makes Pinocchio no longer hold the round hostage by preventing round-end from triggering when all R-corp members die

  • Yeah, thats a thing

Makes getting any R-corp objective at round-end make some confetti instead of giving a big red text

  • Round's already over, sadly you cannot get an R-corp victory when you've already lost

Changelog

🆑
fix: Pinocchio no longer stops round restarts
/:cl:

@Gboster-0 Gboster-0 added the Fix There was a bug, and we fixed it! label Jan 4, 2025
@Gboster-0 Gboster-0 changed the title Fixes the round not auto-restarting because of pinocchio, removes the announcement if you destroy the R-corp communicator at round-end Fixes round-end not auto-triggering when a player dies on combat maps because of pinocchio + R-corp round-end improvements Jan 4, 2025
Copy link
Contributor

@Kitsunemitsu Kitsunemitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was gonna approve this while drunk as shit a while ago but now that I'm sober, I see no major issues, mostly just cleanup

@Kitsunemitsu Kitsunemitsu merged commit 0669163 into vlggms:master Jan 10, 2025
10 checks passed
@Gboster-0 Gboster-0 deleted the fix-auto-restart branch January 10, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix There was a bug, and we fixed it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants