Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Antagonist welcome Sounds #486

Merged
merged 6 commits into from
Jan 25, 2024
Merged

Conversation

casualspacestation14enjoyer
Copy link
Contributor

About the Pull Request

more sounds to come eventually in separate PRs i swear

Why It's Good For The Game

its a great reminder for players when they become antago

Did you test it?

yup m8 i swear bro fr!

Authorship

Changelog

🆑
rscadd: There are now several welcoming sounds for when you become an antagonist, it's a great reminder!
/:cl:

@EgorDinamit EgorDinamit added the 🔨1 Tweak A small change/addition to already existing systems. label Nov 4, 2023
Copy link
Member

@EgorDinamit EgorDinamit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add it to preferences, so players can disable it at will.
  • Remove/replace operative alert and fallback alert.
  • For traitor alert might as well use the original, the low pitch doesn't help it to sound any better.
  • Wizard alert is fine, but very difficult to notice; Could probably find another sound or do something about that one.

@EgorDinamit
Copy link
Member

Oh, and move the sounds themselves from ambience to somewhere more appropriate.

@casualspacestation14enjoyer
Copy link
Contributor Author

Oh, and move the sounds themselves from ambience to somewhere more appropriate.

I'm pretty sure the ambience folder prevents the game from adding any shitty effects to it, like the echo.

@casualspacestation14enjoyer
Copy link
Contributor Author

  • Add it to preferences, so players can disable it at will.
  • Remove/replace operative alert and fallback alert.
  • For traitor alert might as well use the original, the low pitch doesn't help it to sound any better.
  • Wizard alert is fine, but very difficult to notice; Could probably find another sound or do something about that one.

The fallback alert is for antagonists that aren't standard/admin only, theoretically it shouldn't show up in play. But having a fallback is always a good idea in my opinion. But I'll try and make it sound better.
Nonetheless, I will try and fix the other issues.

@EgorDinamit
Copy link
Member

I'm pretty sure the ambience folder prevents the game from adding any shitty effects to it, like the echo.

Why would it ever work this way..?

@casualspacestation14enjoyer
Copy link
Contributor Author

I'm pretty sure the ambience folder prevents the game from adding any shitty effects to it, like the echo.

Why would it ever work this way..?

  1. Ask the oldcoders.
  2. generally ambience is not 'in-world' so it doesn't happen in the game space but rather for the player only, so the game doesn't apply echoes, or that's how it works i think

@EgorDinamit
Copy link
Member

File's location has nothing to do with how it's played.

@casualspacestation14enjoyer
Copy link
Contributor Author

epic fixed

@goat-ster
Copy link

epic fixed

Based

@EgorDinamit EgorDinamit merged commit 3f9c41f into vlggms:dev Jan 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨1 Tweak A small change/addition to already existing systems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants