Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][AMD][Kernel][Quantization] Add fp8 and int8 support for Triton FAv2 kernel #12534

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

[WIP][AMD][Kernel][Quantization] Add fp8 and int8 support for Triton FAv2 kernel #12534

wants to merge 15 commits into from
+1,356 −414

Conversation

rasmith
Copy link
Contributor

@rasmith rasmith commented Jan 29, 2025 •
edited by github-actions bot
Loading

This is a work in progress at the moment to add fp8 and int8 support for FAv2 kernel.

@rasmith
TritonScaledMMLinearKernel implementation
9e8bad6 
Signed-off-by: Randall Smith <[email protected]>
@rasmith
Add regression test for rocm w8a8
daf9a71 
Signed-off-by: Randall Smith <[email protected]>
@rasmith
remote unused import
9c11d5c 
Signed-off-by: Randall Smith <[email protected]>
@rasmith
ruff
4e4d633 
Signed-off-by: Randall Smith <[email protected]>
@rasmith
adding rocm fp8 support
16cfc92 
Signed-off-by: Randall Smith <[email protected]>
@rasmith
first successful execution
5e0ada7 
Signed-off-by: Randall Smith <[email protected]>
@rasmith
remove prints
481ea60 
Signed-off-by: Randall Smith <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify Mergify
Copy link

mergify bot commented Jan 29, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @rasmith.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added documentation Improvements or additions to documentation needs-rebase labels Jan 29, 2025
@rasmith rasmith marked this pull request as draft January 29, 2025 00:08
shahedy2276541
shahedy2276541 approved these changes Jan 29, 2025
View reviewed changes
vllm/attention/backends/flash_attn.py Outdated
@@ -227,6 +227,7 @@ def prefill_metadata(self) -> Optional["FlashAttentionMetadata"]:
slot_mapping=slot_mapping,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rasmith
Merge upstream
2de123f 
Signed-off-by: Randall Smith <[email protected]>
@mergify mergify bot removed the needs-rebase label Jan 29, 2025
@rasmith
typo fix
0369a6d 
Signed-off-by: Randall Smith <[email protected]>
@rasmith
typo fix
4ff10e4 
Signed-off-by: Randall Smith <[email protected]>
@rasmith
typo fix
b5f045d 
Signed-off-by: Randall Smith <[email protected]>
@rasmith
typo fix
58ea057 
Signed-off-by: Randall Smith <[email protected]>
@rasmith
typo fix
3ac3f08 
Signed-off-by: Randall Smith <[email protected]>
@rasmith
fix merge
00cae8d 
Signed-off-by: Randall Smith <[email protected]>
@rasmith
fix compiler error
a322dc6 
Signed-off-by: Randall Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahedy2276541 shahedy2276541 shahedy2276541 approved these changes

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337

@ywang96 ywang96 Awaiting requested review from ywang96

@mgoin mgoin Awaiting requested review from mgoin mgoin is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123 zhuohan123 is a code owner

@youkaichao youkaichao Awaiting requested review from youkaichao youkaichao is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation rocm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rasmith @shahedy2276541 @hongxiayang