Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support jetson AGX Orin #9109

Closed
wants to merge 4 commits into from
Closed

Conversation

johnnynunez
Copy link

No description provided.

Copy link

github-actions bot commented Oct 6, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want the wheel to support this, you need to also change the dockerfile

ARG torch_cuda_arch_list='7.0 7.5 8.0 8.6 8.9 9.0+PTX'

We can look at the impact on the wheel size after to help make a decision.

@johnnynunez
Copy link
Author

johnnynunez commented Oct 8, 2024

If you want the wheel to support this, you need to also change the dockerfile

ARG torch_cuda_arch_list='7.0 7.5 8.0 8.6 8.9 9.0+PTX'

We can look at the impact on the wheel size after to help make a decision.

but it is arm, so the wheel of the dockerfile must be arm, it is different. So, I'm building vllm in jetson-containers.
Only put in on the scripts, it is sufficient
http://jetson.webredirect.org/jp6/cu126 https://github.com/dusty-nv/jetson-containers/tree/master/packages/llm/vllm

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 9, 2024
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I think it is reasonable for us to allow building for this platform, although it would be nice if users wouldn't build for it by default

@mergify mergify bot added the ci/build label Nov 26, 2024
Copy link

mergify bot commented Nov 26, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @johnnynunez.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Nov 26, 2024
@mergify mergify bot removed the needs-rebase label Nov 26, 2024
@johnnynunez
Copy link
Author

johnnynunez commented Nov 26, 2024

@mgoin
jetson thor is coming, and jetson agx orin will be supported until 2032
image

@dusty-nv

@mgoin
Copy link
Member

mgoin commented Nov 26, 2024

@johnnynunez please see this PR instead #9735

@johnnynunez
Copy link
Author

@johnnynunez please see this PR instead #9735

Uoh perfect. We have right now running on jetson-containers but it is not optimized at all

Copy link

mergify bot commented Nov 26, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @johnnynunez.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Nov 26, 2024
@mgoin
Copy link
Member

mgoin commented Nov 26, 2024

Thanks - Closing as completed!

@mgoin mgoin closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build needs-rebase ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants