update memcached #1541
Annotations
1 error and 217 warnings
test-skylake4x
Process completed with exit code 101.
|
clamp-like pattern without using clamp function:
lib/vmxnet3/src/lib.rs#L67
warning: clamp-like pattern without using clamp function
--> lib/vmxnet3/src/lib.rs:67:30
|
67 | *self = BoundedUSize(n.min(Self::HIGH).max(Self::LOW))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `n.clamp(Self::LOW, Self::HIGH)`
|
= note: clamp will panic if max < min
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp
|
clamp-like pattern without using clamp function:
lib/vmxnet3/src/lib.rs#L55
warning: clamp-like pattern without using clamp function
--> lib/vmxnet3/src/lib.rs:55:22
|
55 | BoundedUSize(n.min(Self::HIGH).max(Self::LOW))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `n.clamp(Self::LOW, Self::HIGH)`
|
= note: clamp will panic if max < min
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp
|
clamp-like pattern without using clamp function:
lib/vmxnet3/src/lib.rs#L35
warning: clamp-like pattern without using clamp function
--> lib/vmxnet3/src/lib.rs:35:28
|
35 | *self = BoundedU32(n.min(Self::HIGH).max(Self::LOW))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `n.clamp(Self::LOW, Self::HIGH)`
|
= note: clamp will panic if max < min
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp
|
clamp-like pattern without using clamp function:
lib/vmxnet3/src/lib.rs#L23
warning: clamp-like pattern without using clamp function
--> lib/vmxnet3/src/lib.rs:23:20
|
23 | BoundedU32(n.min(Self::HIGH).max(Self::LOW))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `n.clamp(Self::LOW, Self::HIGH)`
|
= note: clamp will panic if max < min
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp
= note: `#[warn(clippy::manual_clamp)]` on by default
|
casting to the same type is unnecessary (`u32` -> `u32`):
lib/vmxnet3/src/vmx.rs#L376
warning: casting to the same type is unnecessary (`u32` -> `u32`)
--> lib/vmxnet3/src/vmx.rs:376:48
|
376 | self.pci.write_bar1(VMXNET3_BAR1_MACH, mh as u32);
| ^^^^^^^^^ help: try: `mh`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
casting to the same type is unnecessary (`u32` -> `u32`):
lib/vmxnet3/src/vmx.rs#L373
warning: casting to the same type is unnecessary (`u32` -> `u32`)
--> lib/vmxnet3/src/vmx.rs:373:48
|
373 | self.pci.write_bar1(VMXNET3_BAR1_MACL, ml as u32);
| ^^^^^^^^^ help: try: `ml`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
this operation has no effect:
lib/vmxnet3/src/vmx.rs#L352
warning: this operation has no effect
--> lib/vmxnet3/src/vmx.rs:352:26
|
352 | self.lladdr[4] = (high >> 0) as u8;
| ^^^^^^^^^^^ help: consider reducing it to: `high`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
this operation has no effect:
lib/vmxnet3/src/vmx.rs#L348
warning: this operation has no effect
--> lib/vmxnet3/src/vmx.rs:348:26
|
348 | self.lladdr[0] = (low >> 0) as u8;
| ^^^^^^^^^^ help: consider reducing it to: `low`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
length comparison to zero:
lib/vmxnet3/src/vmx.rs#L283
warning: length comparison to zero
--> lib/vmxnet3/src/vmx.rs:283:12
|
283 | if self.rxq.len() > 0 {
| ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.rxq.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default
|
the variable `i` is used as a loop counter:
lib/vmxnet3/src/var.rs#L651
warning: the variable `i` is used as a loop counter
--> lib/vmxnet3/src/var.rs:651:9
|
651 | for chain in chain.segments.iter() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, chain) in chain.segments.iter().enumerate()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
= note: `#[warn(clippy::explicit_counter_loop)]` on by default
|
unneeded `return` statement:
lib/vmxnet3/src/var.rs#L597
warning: unneeded `return` statement
--> lib/vmxnet3/src/var.rs:597:13
|
597 | return self.pidx_tail0 - self.pidx_head0;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= help: remove `return`
|
unneeded `return` statement:
lib/vmxnet3/src/var.rs#L595
warning: unneeded `return` statement
--> lib/vmxnet3/src/var.rs:595:13
|
595 | return self.pidx_head0 - self.pidx_tail0;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
= help: remove `return`
|
this operation has no effect:
lib/vmxnet3/src/var.rs#L583
warning: this operation has no effect
--> lib/vmxnet3/src/var.rs:583:55
|
583 | vxrxq_comp_ring: vmxnet3_rxcomp_ring::new(1 * ndesc)?,
| ^^^^^^^^^ help: consider reducing it to: `ndesc`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
= note: `#[warn(clippy::identity_op)]` on by default
|
casting to the same type is unnecessary (`usize` -> `usize`):
lib/vmxnet3/src/var.rs#L498
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> lib/vmxnet3/src/var.rs:498:33
|
498 | let txcd = txc.vxcr[txc.vxcr_next as usize];
| ^^^^^^^^^^^^^^^^^^^^^^ help: try: `txc.vxcr_next`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
casting to the same type is unnecessary (`u32` -> `u32`):
lib/vmxnet3/src/var.rs#L405
warning: casting to the same type is unnecessary (`u32` -> `u32`)
--> lib/vmxnet3/src/var.rs:405:25
|
405 | txd.set_gen(gen as u32);
| ^^^^^^^^^^ help: try: `gen`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
this boolean expression can be simplified:
lib/vmxnet3/src/smoltcp.rs#L230
warning: this boolean expression can be simplified
--> lib/vmxnet3/src/smoltcp.rs:230:12
|
230 | if !self.iobuf.is_none() {
| ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.iobuf.is_some()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
= note: `#[warn(clippy::nonminimal_bool)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/vmxnet3/src/smoltcp.rs#L212
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/vmxnet3/src/smoltcp.rs:212:24
|
212 | let result = f(&mut iobuf.segments[0].as_mut_slice());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `iobuf.segments[0].as_mut_slice()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/vmxnet3/src/smoltcp.rs#L171
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/vmxnet3/src/smoltcp.rs:171:24
|
171 | let result = f(&mut self.iobuf.segments[0].as_mut_slice());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.iobuf.segments[0].as_mut_slice()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1085
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1085:37
|
1085 | let gen: u32 = unsafe { ::core::mem::transmute(gen) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1081
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1081:39
|
1081 | let type_: u32 = unsafe { ::core::mem::transmute(type_) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1077
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1077:37
|
1077 | let fcs: u32 = unsafe { ::core::mem::transmute(fcs) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1073
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1073:42
|
1073 | let fragment: u32 = unsafe { ::core::mem::transmute(fragment) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1069
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1069:38
|
1069 | let ipv4: u32 = unsafe { ::core::mem::transmute(ipv4) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1065
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1065:38
|
1065 | let ipv6: u32 = unsafe { ::core::mem::transmute(ipv6) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1061
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1061:43
|
1061 | let ipcsum_ok: u32 = unsafe { ::core::mem::transmute(ipcsum_ok) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1057
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1057:37
|
1057 | let tcp: u32 = unsafe { ::core::mem::transmute(tcp) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1053
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1053:37
|
1053 | let udp: u32 = unsafe { ::core::mem::transmute(udp) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1049
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1049:41
|
1049 | let csum_ok: u32 = unsafe { ::core::mem::transmute(csum_ok) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1045
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1045:38
|
1045 | let csum: u32 = unsafe { ::core::mem::transmute(csum) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1041
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1041:38
|
1041 | let vtag: u32 = unsafe { ::core::mem::transmute(vtag) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1037
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1037:38
|
1037 | let vlan: u32 = unsafe { ::core::mem::transmute(vlan) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1033
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1033:39
|
1033 | let error: u32 = unsafe { ::core::mem::transmute(error) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1029
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1029:37
|
1029 | let len: u32 = unsafe { ::core::mem::transmute(len) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1025
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1025:42
|
1025 | let rss_hash: u32 = unsafe { ::core::mem::transmute(rss_hash) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1021
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1021:38
|
1021 | let pad2: u32 = unsafe { ::core::mem::transmute(pad2) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1017
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1017:41
|
1017 | let no_csum: u32 = unsafe { ::core::mem::transmute(no_csum) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1013
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1013:42
|
1013 | let rss_type: u32 = unsafe { ::core::mem::transmute(rss_type) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1009
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1009:37
|
1009 | let qid: u32 = unsafe { ::core::mem::transmute(qid) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1005
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1005:37
|
1005 | let sop: u32 = unsafe { ::core::mem::transmute(sop) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L1001
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:1001:37
|
1001 | let eop: u32 = unsafe { ::core::mem::transmute(eop) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L997
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:997:38
|
997 | let pad1: u32 = unsafe { ::core::mem::transmute(pad1) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L993
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:993:41
|
993 | let rxd_idx: u32 = unsafe { ::core::mem::transmute(rxd_idx) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
this function has too many arguments (24/7):
lib/vmxnet3/src/reg.rs#L965
warning: this function has too many arguments (24/7)
--> lib/vmxnet3/src/reg.rs:965:5
|
965 | / pub fn new_bitfield_1(
966 | | rxd_idx: u32,
967 | | pad1: u32,
968 | | eop: u32,
... |
989 | | gen: u32,
990 | | ) -> __BindgenBitfieldUnit<[u8; 16usize]> {
| |_____________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L960
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:960:28
|
960 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L955
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:955:18
|
955 | unsafe { ::core::mem::transmute(self._bitfield_1.get(127usize, 1u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L949
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:949:28
|
949 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L944
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:944:18
|
944 | unsafe { ::core::mem::transmute(self._bitfield_1.get(120usize, 7u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`bool`) to itself:
lib/vmxnet3/src/reg.rs#L936
warning: transmute from a type (`bool`) to itself
--> lib/vmxnet3/src/reg.rs:936:18
|
936 | unsafe { ::core::mem::transmute(self._bitfield_1.get(119usize, 1u8) != 0) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`bool`) to itself:
lib/vmxnet3/src/reg.rs#L928
warning: transmute from a type (`bool`) to itself
--> lib/vmxnet3/src/reg.rs:928:18
|
928 | unsafe { ::core::mem::transmute(self._bitfield_1.get(118usize, 1u8) != 0) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`bool`) to itself:
lib/vmxnet3/src/reg.rs#L920
warning: transmute from a type (`bool`) to itself
--> lib/vmxnet3/src/reg.rs:920:18
|
920 | unsafe { ::core::mem::transmute(self._bitfield_1.get(117usize, 1u8) != 0) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`bool`) to itself:
lib/vmxnet3/src/reg.rs#L912
warning: transmute from a type (`bool`) to itself
--> lib/vmxnet3/src/reg.rs:912:18
|
912 | unsafe { ::core::mem::transmute(self._bitfield_1.get(116usize, 1u8) != 0) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`bool`) to itself:
lib/vmxnet3/src/reg.rs#L904
warning: transmute from a type (`bool`) to itself
--> lib/vmxnet3/src/reg.rs:904:18
|
904 | unsafe { ::core::mem::transmute(self._bitfield_1.get(115usize, 1u8) != 0) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`bool`) to itself:
lib/vmxnet3/src/reg.rs#L896
warning: transmute from a type (`bool`) to itself
--> lib/vmxnet3/src/reg.rs:896:18
|
896 | unsafe { ::core::mem::transmute(self._bitfield_1.get(114usize, 1u8) != 0) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`bool`) to itself:
lib/vmxnet3/src/reg.rs#L888
warning: transmute from a type (`bool`) to itself
--> lib/vmxnet3/src/reg.rs:888:18
|
888 | unsafe { ::core::mem::transmute(self._bitfield_1.get(113usize, 1u8) != 0) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`bool`) to itself:
lib/vmxnet3/src/reg.rs#L880
warning: transmute from a type (`bool`) to itself
--> lib/vmxnet3/src/reg.rs:880:18
|
880 | unsafe { ::core::mem::transmute(self._bitfield_1.get(112usize, 1u8) != 0) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L874
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:874:28
|
874 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L869
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:869:18
|
869 | unsafe { ::core::mem::transmute(self._bitfield_1.get(96usize, 16u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L863
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:863:28
|
863 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L858
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:858:18
|
858 | unsafe { ::core::mem::transmute(self._bitfield_1.get(80usize, 16u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`bool`) to itself:
lib/vmxnet3/src/reg.rs#L850
warning: transmute from a type (`bool`) to itself
--> lib/vmxnet3/src/reg.rs:850:18
|
850 | unsafe { ::core::mem::transmute(self._bitfield_1.get(79usize, 1u8) != 0) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`bool`) to itself:
lib/vmxnet3/src/reg.rs#L842
warning: transmute from a type (`bool`) to itself
--> lib/vmxnet3/src/reg.rs:842:18
|
842 | unsafe { ::core::mem::transmute(self._bitfield_1.get(78usize, 1u8) != 0) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L836
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:836:28
|
836 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L831
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:831:18
|
831 | unsafe { ::core::mem::transmute(self._bitfield_1.get(64usize, 14u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
struct `vmxnet3_rxcompdesc` has a public `len` method, but no `is_empty` method:
lib/vmxnet3/src/reg.rs#L830
warning: struct `vmxnet3_rxcompdesc` has a public `len` method, but no `is_empty` method
--> lib/vmxnet3/src/reg.rs:830:5
|
830 | pub fn len(&self) -> u32 {
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L825
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:825:28
|
825 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L820
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:820:18
|
820 | unsafe { ::core::mem::transmute(self._bitfield_1.get(32usize, 32u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`bool`) to itself:
lib/vmxnet3/src/reg.rs#L812
warning: transmute from a type (`bool`) to itself
--> lib/vmxnet3/src/reg.rs:812:18
|
812 | unsafe { ::core::mem::transmute(self._bitfield_1.get(31usize, 1u8) != 0) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`bool`) to itself:
lib/vmxnet3/src/reg.rs#L804
warning: transmute from a type (`bool`) to itself
--> lib/vmxnet3/src/reg.rs:804:18
|
804 | unsafe { ::core::mem::transmute(self._bitfield_1.get(30usize, 1u8) != 0) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L798
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:798:28
|
798 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L793
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:793:18
|
793 | unsafe { ::core::mem::transmute(self._bitfield_1.get(26usize, 4u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L787
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:787:28
|
787 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L782
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:782:18
|
782 | unsafe { ::core::mem::transmute(self._bitfield_1.get(16usize, 10u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`bool`) to itself:
lib/vmxnet3/src/reg.rs#L774
warning: transmute from a type (`bool`) to itself
--> lib/vmxnet3/src/reg.rs:774:18
|
774 | unsafe { ::core::mem::transmute(self._bitfield_1.get(15usize, 1u8) != 0) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`bool`) to itself:
lib/vmxnet3/src/reg.rs#L766
warning: transmute from a type (`bool`) to itself
--> lib/vmxnet3/src/reg.rs:766:18
|
766 | unsafe { ::core::mem::transmute(self._bitfield_1.get(14usize, 1u8) != 0) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L760
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:760:28
|
760 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L755
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:755:18
|
755 | unsafe { ::core::mem::transmute(self._bitfield_1.get(12usize, 2u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L749
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:749:28
|
749 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L744
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:744:18
|
744 | unsafe { ::core::mem::transmute(self._bitfield_1.get(0usize, 12u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L699
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:699:38
|
699 | let pad1: u32 = unsafe { ::core::mem::transmute(pad1) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L695
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:695:37
|
695 | let gen: u32 = unsafe { ::core::mem::transmute(gen) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L691
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:691:38
|
691 | let rsvd: u32 = unsafe { ::core::mem::transmute(rsvd) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L687
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:687:39
|
687 | let dtype: u32 = unsafe { ::core::mem::transmute(dtype) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L683
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:683:39
|
683 | let btype: u32 = unsafe { ::core::mem::transmute(btype) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L679
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:679:37
|
679 | let len: u32 = unsafe { ::core::mem::transmute(len) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L664
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:664:28
|
664 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L659
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:659:18
|
659 | unsafe { ::core::mem::transmute(self._bitfield_1.get(32usize, 32u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L653
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:653:28
|
653 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L648
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:648:18
|
648 | unsafe { ::core::mem::transmute(self._bitfield_1.get(31usize, 1u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L642
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:642:28
|
642 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L637
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:637:18
|
637 | unsafe { ::core::mem::transmute(self._bitfield_1.get(16usize, 15u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L631
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:631:28
|
631 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L626
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:626:18
|
626 | unsafe { ::core::mem::transmute(self._bitfield_1.get(15usize, 1u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L620
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:620:28
|
620 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L615
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:615:18
|
615 | unsafe { ::core::mem::transmute(self._bitfield_1.get(14usize, 1u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L609
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:609:28
|
609 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L604
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:604:18
|
604 | unsafe { ::core::mem::transmute(self._bitfield_1.get(0usize, 14u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
struct `vmxnet3_rxdesc` has a public `len` method, but no `is_empty` method:
lib/vmxnet3/src/reg.rs#L603
warning: struct `vmxnet3_rxdesc` has a public `len` method, but no `is_empty` method
--> lib/vmxnet3/src/reg.rs:603:5
|
603 | pub fn len(&self) -> u32 {
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L575
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:575:37
|
575 | let gen: u32 = unsafe { ::core::mem::transmute(gen) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L571
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:571:39
|
571 | let type_: u32 = unsafe { ::core::mem::transmute(type_) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L567
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:567:38
|
567 | let rsvd: u32 = unsafe { ::core::mem::transmute(rsvd) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L563
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:563:38
|
563 | let pad3: u32 = unsafe { ::core::mem::transmute(pad3) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L559
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:559:38
|
559 | let pad2: u32 = unsafe { ::core::mem::transmute(pad2) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L555
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:555:38
|
555 | let pad1: u32 = unsafe { ::core::mem::transmute(pad1) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L551
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:551:41
|
551 | let eop_idx: u32 = unsafe { ::core::mem::transmute(eop_idx) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L535
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:535:28
|
535 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L530
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:530:18
|
530 | unsafe { ::core::mem::transmute(self._bitfield_1.get(127usize, 1u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L524
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:524:28
|
524 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L519
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:519:18
|
519 | unsafe { ::core::mem::transmute(self._bitfield_1.get(120usize, 7u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L513
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:513:28
|
513 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L508
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:508:18
|
508 | unsafe { ::core::mem::transmute(self._bitfield_1.get(96usize, 24u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L502
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:502:28
|
502 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L497
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:497:18
|
497 | unsafe { ::core::mem::transmute(self._bitfield_1.get(64usize, 32u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L491
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:491:28
|
491 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L486
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:486:18
|
486 | unsafe { ::core::mem::transmute(self._bitfield_1.get(32usize, 32u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L480
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:480:28
|
480 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L475
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:475:18
|
475 | unsafe { ::core::mem::transmute(self._bitfield_1.get(12usize, 20u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L469
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:469:28
|
469 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L464
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:464:18
|
464 | unsafe { ::core::mem::transmute(self._bitfield_1.get(0usize, 12u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L438
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:438:38
|
438 | let vtag: u32 = unsafe { ::core::mem::transmute(vtag) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L434
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:434:43
|
434 | let vtag_mode: u32 = unsafe { ::core::mem::transmute(vtag_mode) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L430
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:430:38
|
430 | let pad3: u32 = unsafe { ::core::mem::transmute(pad3) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L426
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:426:41
|
426 | let compreq: u32 = unsafe { ::core::mem::transmute(compreq) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L422
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:422:37
|
422 | let eop: u32 = unsafe { ::core::mem::transmute(eop) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L418
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:418:46
|
418 | let offload_mode: u32 = unsafe { ::core::mem::transmute(offload_mode) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L414
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:414:38
|
414 | let hlen: u32 = unsafe { ::core::mem::transmute(hlen) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L410
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:410:45
|
410 | let offload_pos: u32 = unsafe { ::core::mem::transmute(offload_pos) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L406
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:406:38
|
406 | let pad2: u32 = unsafe { ::core::mem::transmute(pad2) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L402
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:402:39
|
402 | let dtype: u32 = unsafe { ::core::mem::transmute(dtype) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L398
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:398:38
|
398 | let pad1: u32 = unsafe { ::core::mem::transmute(pad1) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L394
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:394:37
|
394 | let gen: u32 = unsafe { ::core::mem::transmute(gen) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L390
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:390:37
|
390 | let len: u32 = unsafe { ::core::mem::transmute(len) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
this function has too many arguments (13/7):
lib/vmxnet3/src/reg.rs#L373
warning: this function has too many arguments (13/7)
--> lib/vmxnet3/src/reg.rs:373:5
|
373 | / pub fn new_bitfield_1(
374 | | len: u32,
375 | | gen: u32,
376 | | pad1: u32,
... |
386 | | vtag: u32,
387 | | ) -> __BindgenBitfieldUnit<[u8; 8usize]> {
| |____________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L368
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:368:28
|
368 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L363
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:363:18
|
363 | unsafe { ::core::mem::transmute(self._bitfield_1.get(48usize, 16u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration):
lib/node-replication/nr/src/lib.rs#L121
warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
--> lib/node-replication/nr/src/lib.rs:121:5
|
121 | fn dispatch<'a>(&self, op: Self::ReadOperation<'a>) -> Self::Response;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L357
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:357:28
|
357 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L352
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:352:18
|
352 | unsafe { ::core::mem::transmute(self._bitfield_1.get(47usize, 1u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L346
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:346:28
|
346 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L341
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:341:18
|
341 | unsafe { ::core::mem::transmute(self._bitfield_1.get(46usize, 1u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L335
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:335:28
|
335 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L330
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:330:18
|
330 | unsafe { ::core::mem::transmute(self._bitfield_1.get(45usize, 1u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L324
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:324:28
|
324 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L319
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:319:18
|
319 | unsafe { ::core::mem::transmute(self._bitfield_1.get(44usize, 1u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L313
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:313:28
|
313 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L308
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:308:18
|
308 | unsafe { ::core::mem::transmute(self._bitfield_1.get(42usize, 2u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L302
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:302:28
|
302 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L297
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:297:18
|
297 | unsafe { ::core::mem::transmute(self._bitfield_1.get(32usize, 10u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L291
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:291:28
|
291 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L286
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:286:18
|
286 | unsafe { ::core::mem::transmute(self._bitfield_1.get(18usize, 14u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L280
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:280:28
|
280 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L275
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:275:18
|
275 | unsafe { ::core::mem::transmute(self._bitfield_1.get(17usize, 1u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L269
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:269:28
|
269 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L264
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:264:18
|
264 | unsafe { ::core::mem::transmute(self._bitfield_1.get(16usize, 1u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L258
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:258:28
|
258 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L253
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:253:18
|
253 | unsafe { ::core::mem::transmute(self._bitfield_1.get(15usize, 1u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L247
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:247:28
|
247 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L242
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:242:18
|
242 | unsafe { ::core::mem::transmute(self._bitfield_1.get(14usize, 1u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L236
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:236:28
|
236 | let val: u32 = ::core::mem::transmute(val);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
|
transmute from a type (`u32`) to itself:
lib/vmxnet3/src/reg.rs#L231
warning: transmute from a type (`u32`) to itself
--> lib/vmxnet3/src/reg.rs:231:18
|
231 | unsafe { ::core::mem::transmute(self._bitfield_1.get(0usize, 14u8) as u32) }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute
= note: `#[warn(clippy::useless_transmute)]` on by default
|
struct `vmxnet3_txdesc` has a public `len` method, but no `is_empty` method:
lib/vmxnet3/src/reg.rs#L230
warning: struct `vmxnet3_txdesc` has a public `len` method, but no `is_empty` method
--> lib/vmxnet3/src/reg.rs:230:5
|
230 | pub fn len(&self) -> u32 {
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
= note: `#[warn(clippy::len_without_is_empty)]` on by default
|
explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration):
lib/node-replication/nr/src/replica.rs#L504
warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
--> lib/node-replication/nr/src/replica.rs:504:5
|
504 | / fn read_only<'rop>(
505 | | &self,
506 | | op: <D as Dispatch>::ReadOperation<'rop>,
507 | | tid: usize,
508 | | ) -> <D as Dispatch>::Response {
| |__________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
|
called `unwrap` on `r` after checking its variant with `is_some`:
lib/node-replication/nr/src/replica.rs#L444
warning: called `unwrap` on `r` after checking its variant with `is_some`
--> lib/node-replication/nr/src/replica.rs:444:24
|
443 | if r.is_some() {
| -------------- help: try: `if let Some(..) = r`
444 | return r.unwrap();
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
= note: `#[warn(clippy::unnecessary_unwrap)]` on by default
|
explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration):
lib/node-replication/nr/src/replica.rs#L425
warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
--> lib/node-replication/nr/src/replica.rs:425:5
|
425 | / pub fn execute<'rop>(
426 | | &self,
427 | | op: <D as Dispatch>::ReadOperation<'rop>,
428 | | idx: ReplicaToken,
429 | | ) -> <D as Dispatch>::Response {
| |__________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
|
casting to the same type is unnecessary (`u32` -> `u32`):
lib/vmxnet3/src/pci.rs#L20
warning: casting to the same type is unnecessary (`u32` -> `u32`)
--> lib/vmxnet3/src/pci.rs:20:59
|
20 | (1 << 31) | (bus << 16) | (dev << 11) | (fun << 8) | (reg as u32 & 0xfc)
| ^^^^^^^^^^ help: try: `reg`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
the loop variable `i` is used to index `ops`:
lib/node-replication/nr/src/log.rs#L402
warning: the loop variable `i` is used to index `ops`
--> lib/node-replication/nr/src/log.rs:402:22
|
402 | for i in 0..nops {
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator
|
402 | for (i, <item>) in ops.iter().enumerate().take(nops) {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
the loop variable `idx` is only used to index `fls`:
lib/node-replication/nr/src/log.rs#L226
warning: the loop variable `idx` is only used to index `fls`
--> lib/node-replication/nr/src/log.rs:226:20
|
226 | for idx in 0..MAX_REPLICAS_PER_LOG {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator
|
226 | for <item> in fls.iter().take(MAX_REPLICAS_PER_LOG) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
the loop variable `i` is used to index `responses`:
lib/node-replication/nr/src/context.rs#L123
warning: the loop variable `i` is used to index `responses`
--> lib/node-replication/nr/src/context.rs:123:18
|
123 | for i in 0..n {
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
= note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator
|
123 | for (i, <item>) in responses.iter().enumerate().take(n) {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
redundant field names in struct initialization:
lib/vmxnet3/src/vmx.rs#L76
warning: redundant field names in struct initialization
--> lib/vmxnet3/src/vmx.rs:76:17
|
76 | layout: layout,
| ^^^^^^^^^^^^^^ help: replace it with: `layout`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
redundant field names in struct initialization:
lib/vmxnet3/src/var.rs#L264
warning: redundant field names in struct initialization
--> lib/vmxnet3/src/var.rs:264:13
|
264 | vxcr: vxcr,
| ^^^^^^^^^^ help: replace it with: `vxcr`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
redundant field names in struct initialization:
lib/vmxnet3/src/var.rs#L220
warning: redundant field names in struct initialization
--> lib/vmxnet3/src/var.rs:220:13
|
220 | vxcr: vxcr,
| ^^^^^^^^^^ help: replace it with: `vxcr`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
= note: `#[warn(clippy::redundant_field_names)]` on by default
|
the feature `generic_associated_types` has been stable since 1.65.0 and no longer requires an attribute to enable:
lib/node-replication/nr/src/lib.rs#L71
warning: the feature `generic_associated_types` has been stable since 1.65.0 and no longer requires an attribute to enable
--> lib/node-replication/nr/src/lib.rs:71:12
|
71 | #![feature(generic_associated_types)]
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(stable_features)]` on by default
|
this let-binding has unit value:
lib/node-replication2/node-replication/src/nr/mod.rs#L941
warning: this let-binding has unit value
--> lib/node-replication2/node-replication/src/nr/mod.rs:941:17
|
941 | let _r: () = self.try_combine(tkn).unwrap();
| ^^^^--^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| help: use a wild (`_`) binding: `_`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
a `const` item should never be interior mutable:
lib/node-replication2/node-replication/src/nr/mod.rs#L441
warning: a `const` item should never be interior mutable
--> lib/node-replication2/node-replication/src/nr/mod.rs:441:9
|
441 | const THREAD_ROUTING_DEFAULT: AtomicBitmap = DEFAULT_BITMAP;
| -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| make this a static item (maybe with lazy_static)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const
|
a `const` item should never be interior mutable:
lib/node-replication2/node-replication/src/nr/atomic_bitmap.rs#L7
warning: a `const` item should never be interior mutable
--> lib/node-replication2/node-replication/src/nr/atomic_bitmap.rs:7:1
|
7 | pub const DEFAULT_BITMAP: AtomicBitmap = AtomicBitmap {
| ^----
| |
| _make this a static item (maybe with lazy_static)
| |
8 | | data: [AtomicU64::new(0), AtomicU64::new(0)],
9 | | };
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const
= note: `#[warn(clippy::declare_interior_mutable_const)]` on by default
|
explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration):
lib/node-replication/cnr/src/lib.rs#L166
warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
--> lib/node-replication/cnr/src/lib.rs:166:5
|
166 | fn dispatch<'a>(&self, op: Self::ReadOperation<'a>) -> Self::Response;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
|
the loop variable `logidx` is used to index `tails`:
lib/node-replication/cnr/src/replica.rs#L1076
warning: the loop variable `logidx` is used to index `tails`
--> lib/node-replication/cnr/src/replica.rs:1076:23
|
1076 | for logidx in start..end {
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator
|
1076 | for (logidx, <item>) in tails.iter().enumerate().take(end).skip(start) {
| ~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
lib/node-replication/cnr/src/replica.rs#L1074
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> lib/node-replication/cnr/src/replica.rs:1074:73
|
1074 | fn is_replica_sync_for_logs(&self, start: usize, end: usize, tails: &Vec<usize>) -> bool {
| ^^^^^^^^^^^ help: change this to: `&[usize]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
|
unneeded `return` statement:
lib/node-replication/cnr/src/replica.rs#L1084
warning: unneeded `return` statement
--> lib/node-replication/cnr/src/replica.rs:1084:9
|
1084 | return is_synced;
| ^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= help: remove `return`
|
the loop variable `logidx` is used to index `depends_on`:
lib/node-replication/cnr/src/replica.rs#L1042
warning: the loop variable `logidx` is used to index `depends_on`
--> lib/node-replication/cnr/src/replica.rs:1042:31
|
1042 | for logidx in 1..self.logstate.len() {
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator
|
1042 | for (logidx, <item>) in depends_on.iter().enumerate().take(self.logstate.len()).skip(1) {
| ~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
unneeded `return` statement:
lib/node-replication/cnr/src/replica.rs#L1059
warning: unneeded `return` statement
--> lib/node-replication/cnr/src/replica.rs:1059:30
|
1059 | false => return false,
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= help: remove `return`
|
unneeded `return` statement:
lib/node-replication/cnr/src/replica.rs#L1057
warning: unneeded `return` statement
--> lib/node-replication/cnr/src/replica.rs:1057:25
|
1057 | return true;
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= help: remove `return`
|
unneeded `return` statement:
lib/node-replication/cnr/src/replica.rs#L1035
warning: unneeded `return` statement
--> lib/node-replication/cnr/src/replica.rs:1035:25
|
1035 | return self.is_replica_sync_for_logs(logidx, logidx + 1, depends_on);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= help: remove `return`
|
unneeded `return` statement:
lib/node-replication/cnr/src/replica.rs#L1032
warning: unneeded `return` statement
--> lib/node-replication/cnr/src/replica.rs:1032:29
|
1032 | true => return true,
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= help: remove `return`
|
unneeded `return` statement:
lib/node-replication/cnr/src/replica.rs#L1001
warning: unneeded `return` statement
--> lib/node-replication/cnr/src/replica.rs:1001:25
|
1001 | return self.handle_scan_op(o, thread_id, hashidx, rid, tid, depends_on);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= help: remove `return`
|
unneeded `return` statement:
lib/node-replication/cnr/src/replica.rs#L997
warning: unneeded `return` statement
--> lib/node-replication/cnr/src/replica.rs:997:25
|
997 | return true;
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= help: remove `return`
|
unneeded `return` statement:
lib/node-replication/cnr/src/replica.rs#L970
warning: unneeded `return` statement
--> lib/node-replication/cnr/src/replica.rs:970:25
|
970 | return self.handle_scan_op(o, thread_id, hashidx, rid, tid, depends_on);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= help: remove `return`
|
unneeded `return` statement:
lib/node-replication/cnr/src/replica.rs#L966
warning: unneeded `return` statement
--> lib/node-replication/cnr/src/replica.rs:966:25
|
966 | return true;
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= help: remove `return`
|
explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration):
lib/node-replication/cnr/src/replica.rs#L842
warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
--> lib/node-replication/cnr/src/replica.rs:842:5
|
842 | / fn read_only<'rop>(
843 | | &self,
844 | | op: <D as Dispatch>::ReadOperation<'rop>,
845 | | tid: usize,
846 | | ) -> <D as Dispatch>::Response {
| |__________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
|
called `unwrap` on `r` after checking its variant with `is_some`:
lib/node-replication/cnr/src/replica.rs#L760
warning: called `unwrap` on `r` after checking its variant with `is_some`
--> lib/node-replication/cnr/src/replica.rs:760:24
|
759 | if r.is_some() {
| -------------- help: try: `if let Some(..) = r`
760 | return r.unwrap();
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
= note: `#[warn(clippy::unnecessary_unwrap)]` on by default
|
explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration):
lib/node-replication/cnr/src/replica.rs#L741
warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
--> lib/node-replication/cnr/src/replica.rs:741:5
|
741 | / pub fn execute<'rop>(
742 | | &self,
743 | | op: <D as Dispatch>::ReadOperation<'rop>,
744 | | idx: ReplicaToken,
745 | | ) -> <D as Dispatch>::Response {
| |__________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
|
unneeded `return` statement:
lib/node-replication/cnr/src/replica.rs#L635
warning: unneeded `return` statement
--> lib/node-replication/cnr/src/replica.rs:635:29
|
635 | / ... return self
636 | | ... .handle_scan_op(o, thread_id, *logidx, rid, tid, depends_on);
| |______________________________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= help: remove `return`
|
unneeded `return` statement:
lib/node-replication/cnr/src/replica.rs#L631
warning: unneeded `return` statement
--> lib/node-replication/cnr/src/replica.rs:631:29
|
631 | ... return true;
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= help: remove `return`
|
returning the result of a `let` binding from a block:
lib/node-replication/cnr/src/replica.rs#L604
warning: returning the result of a `let` binding from a block
--> lib/node-replication/cnr/src/replica.rs:604:9
|
602 | let resp = self.get_response(idx.0, hash);
| ------------------------------------------ unnecessary `let` binding
603 |
604 | resp
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
602 ~
603 |
604 ~ self.get_response(idx.0, hash)
|
|
redundant clone:
lib/node-replication/cnr/src/replica.rs#L596
warning: redundant clone
--> lib/node-replication/cnr/src/replica.rs:596:29
|
596 | self.make_pending(op.clone(), idx.0, hash, true);
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> lib/node-replication/cnr/src/replica.rs:596:27
|
596 | self.make_pending(op.clone(), idx.0, hash, true);
| ^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
|
redundant clone:
lib/node-replication/cnr/src/replica.rs#L498
warning: redundant clone
--> lib/node-replication/cnr/src/replica.rs:498:29
|
498 | self.make_pending(op.clone(), idx.0, hash, false);
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> lib/node-replication/cnr/src/replica.rs:498:27
|
498 | self.make_pending(op.clone(), idx.0, hash, false);
| ^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: `#[warn(clippy::redundant_clone)]` on by default
|
this `.fold` can be written more succinctly using another method:
lib/kpi/src/syscalls/mod.rs#L28
warning: this `.fold` can be written more succinctly using another method
--> lib/kpi/src/syscalls/mod.rs:28:47
|
28 | let expected_r = PRIMES[range].iter().fold(1, |acc, x| acc * x);
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `product()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
= note: `#[warn(clippy::unnecessary_fold)]` on by default
|
explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration):
lib/node-replication/cnr/src/replica.rs#L274
warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
--> lib/node-replication/cnr/src/replica.rs:274:5
|
274 | / pub fn with_data<'b>(
275 | | logs: Vec<Arc<Log<'b, <D as Dispatch>::WriteOperation>>>,
276 | | d: D,
277 | | ) -> Arc<Replica<'b, D>> {
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
|
explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration):
lib/node-replication/cnr/src/replica.rs#L254
warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
--> lib/node-replication/cnr/src/replica.rs:254:5
|
254 | / pub fn new<'b>(
255 | | logs: Vec<Arc<Log<'b, <D as Dispatch>::WriteOperation>>>,
256 | | ) -> Arc<Replica<'b, D>> {
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
|
length comparison to zero:
lib/kpi/src/syscalls/system.rs#L38
warning: length comparison to zero
--> lib/kpi/src/syscalls/system.rs:38:20
|
38 | if remaining.len() > 0 {
| ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!remaining.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default
|
very complex type used. Consider factoring parts into `type` definitions:
lib/node-replication/cnr/src/replica.rs#L90
warning: very complex type used. Consider factoring parts into `type` definitions
--> lib/node-replication/cnr/src/replica.rs:90:18
|
90 | scan_buffer: CachePadded<RefCell<Vec<(<D as Dispatch>::WriteOperation, usize)>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
very complex type used. Consider factoring parts into `type` definitions:
lib/node-replication/cnr/src/replica.rs#L87
warning: very complex type used. Consider factoring parts into `type` definitions
--> lib/node-replication/cnr/src/replica.rs:87:13
|
87 | buffer: CachePadded<RefCell<Vec<(<D as Dispatch>::WriteOperation, usize)>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
unneeded `return` statement:
lib/node-replication/cnr/src/log.rs#L593
warning: unneeded `return` statement
--> lib/node-replication/cnr/src/log.rs:593:9
|
593 | return true;
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
= help: remove `return`
|
unneeded late initialization:
lib/node-replication/cnr/src/log.rs#L483
warning: unneeded late initialization
--> lib/node-replication/cnr/src/log.rs:483:9
|
483 | let log_offset;
| ^^^^^^^^^^^^^^^ created here
...
515 | log_offset = tail;
| ^^^^^^^^^^^^^^^^^ initialised here
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
= note: `#[warn(clippy::needless_late_init)]` on by default
help: declare `log_offset` here
|
515 | let log_offset = tail;
| ~~~~~~~~~~~~~~
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
lib/node-replication/cnr/src/log.rs#L479
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> lib/node-replication/cnr/src/log.rs:479:17
|
479 | offset: &Vec<usize>,
| ^^^^^^^^^^^ help: change this to: `&[usize]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
the loop variable `i` is used to index `ops`:
lib/node-replication/cnr/src/log.rs#L457
warning: the loop variable `i` is used to index `ops`
--> lib/node-replication/cnr/src/log.rs:457:22
|
457 | for i in 0..nops {
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator
|
457 | for (i, <item>) in ops.iter().enumerate().take(nops) {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
equality checks against true are unnecessary:
lib/node-replication/cnr/src/log.rs#L407
warning: equality checks against true are unnecessary
--> lib/node-replication/cnr/src/log.rs:407:20
|
407 | if is_stuck == true
| ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `is_stuck`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
= note: `#[warn(clippy::bool_comparison)]` on by default
|
the loop variable `idx` is only used to index `fls`:
lib/node-replication/cnr/src/log.rs#L269
warning: the loop variable `idx` is only used to index `fls`
--> lib/node-replication/cnr/src/log.rs:269:20
|
269 | for idx in 0..MAX_REPLICAS_PER_LOG {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator
|
269 | for <item> in fls.iter().take(MAX_REPLICAS_PER_LOG) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
very complex type used. Consider factoring parts into `type` definitions:
lib/node-replication/cnr/src/log.rs#L158
warning: very complex type used. Consider factoring parts into `type` definitions
--> lib/node-replication/cnr/src/log.rs:158:9
|
158 | gc: UnsafeCell<Box<dyn FnMut(&[AtomicBool; MAX_REPLICAS_PER_LOG], usize)>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
attempt to mutate range bound within loop:
lib/node-replication/cnr/src/context.rs#L196
warning: attempt to mutate range bound within loop
--> lib/node-replication/cnr/src/context.rs:196:17
|
196 | h += 1;
| ^
|
= note: the range of the loop is unchanged
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound
= note: `#[warn(clippy::mut_range_bound)]` on by default
|
the loop variable `i` is only used to index `responses`:
lib/node-replication/cnr/src/context.rs#L138
warning: the loop variable `i` is only used to index `responses`
--> lib/node-replication/cnr/src/context.rs:138:18
|
138 | for i in 0..n {
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
= note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator
|
138 | for <item> in responses.iter().take(n) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~
|
field assignment outside of initializer for an instance created with Default::default():
lib/node-replication/cnr/src/context.rs#L92
warning: field assignment outside of initializer for an instance created with Default::default()
--> lib/node-replication/cnr/src/context.rs:92:9
|
92 | context.idx = id;
| ^^^^^^^^^^^^^^^^^
|
note: consider initializing the variable with `Context::<T, R> { idx: id, ..Default::default() }` and removing relevant reassignments
--> lib/node-replication/cnr/src/context.rs:91:9
|
91 | let mut context: Context<T, R> = Default::default();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
= note: `#[warn(clippy::field_reassign_with_default)]` on by default
|
the feature `generic_associated_types` has been stable since 1.65.0 and no longer requires an attribute to enable:
lib/node-replication/cnr/src/lib.rs#L100
warning: the feature `generic_associated_types` has been stable since 1.65.0 and no longer requires an attribute to enable
--> lib/node-replication/cnr/src/lib.rs:100:12
|
100 | #![feature(generic_associated_types)]
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(stable_features)]` on by default
|
the feature `generic_associated_types` has been stable since 1.65.0 and no longer requires an attribute to enable:
lib/node-replication2/node-replication/src/lib.rs#L17
warning: the feature `generic_associated_types` has been stable since 1.65.0 and no longer requires an attribute to enable
--> lib/node-replication2/node-replication/src/lib.rs:17:5
|
17 | generic_associated_types,
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(stable_features)]` on by default
|
`crate` references the macro call's crate:
lib/kpi/src/syscalls/macros.rs#L27
warning: `crate` references the macro call's crate
--> lib/kpi/src/syscalls/macros.rs:27:9
|
27 | crate::syscalls::macros::syscall_1_1($arg0 as u64)
| ^^^^^ help: to reference the macro definition's crate, use: `$crate`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def
= note: `#[warn(clippy::crate_in_macro_def)]` on by default
|
test-skylake4x
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test-skylake4x
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test-skylake4x
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|