Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace oauth2-proxy by louketo-proxy #2115

Closed
wants to merge 1 commit into from

Conversation

kvaps
Copy link
Contributor

@kvaps kvaps commented Oct 15, 2020

Description of the change

This PR replaces oauth2-proxy by louketo-proxy (formerly known as keycloak-gatekeeper).

Benefits

Working integration with Keycloak

Possible drawbacks

Other providers are not tested and do not guaranteed that they will work

Applicable issues

Additional information

This PR provided just for example and does not pretend to be mergedю
Рowever until the better solution for #2111 is found, this is only working method to run kubeapps with internal oauth2 proxy service and Keycloak.

@kvaps kvaps force-pushed the louketo branch 2 times, most recently from 3d980ee to e2b6898 Compare October 15, 2020 14:08
@kvaps kvaps force-pushed the louketo branch 2 times, most recently from 1d9fbbd to 88a0464 Compare October 15, 2020 14:57
@andresmgot
Copy link
Contributor

Thank you for the PR @kvaps! As explained in #2111, we moved away from keycloak-gatekeeper in the past due to different problems regarding integration with different platforms (other than keycloak) so we won't be moving back to it for the moment.

In any case this PR will be helpful for people blocked by #2111 until we find a proper configuration for oauth2_proxy, thanks!

@kvaps
Copy link
Contributor Author

kvaps commented Oct 19, 2020

I can append that louketo is going to be deprecated louketo/louketo-proxy#683

@absoludity
Copy link
Contributor

I can append that louketo is going to be deprecated louketo/louketo-proxy#683

Right, so this PR is useful to show keycloak works with keycloak-gatekeeper/louketo-proxy right, but not for review / landing. I'm closing it on that assumption but please re-open if I've misunderstood. I'll comment on the issue.

@absoludity absoludity closed this Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't login to kubeapps using Keycloak
3 participants