Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Skip reconcile for csi config template #4436

Conversation

adduarte
Copy link

if a csi config is a template, reconciliation loop should be skipped.

What this PR does / why we need it

the reconcile loop for vsphere csi config is skipped if the config is labeled as a template.

Which issue(s) this PR fixes

Fixes #4435

Describe testing done for PR

Release note

vshpere csi config templates are not reconciled by vsphere csi controller

Additional information

Special notes for your reviewer

if a csi config is a template, reconciliation loop should be skipped.
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #4436 (3bfea51) into main (e982ed1) will decrease coverage by 0.95%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4436      +/-   ##
==========================================
- Coverage   49.67%   48.72%   -0.95%     
==========================================
  Files         452      482      +30     
  Lines       45055    47175    +2120     
==========================================
+ Hits        22379    22988     +609     
- Misses      20560    22015    +1455     
- Partials     2116     2172      +56     
Impacted Files Coverage Δ
addons/controllers/clusterbootstrap_controller.go 64.58% <0.00%> (-1.55%) ⬇️
...i/plugin/cluster/delete_machinehealthcheck_node.go 16.66% <0.00%> (ø)
cmd/cli/plugin/cluster/machinehealthcheck.go 100.00% <0.00%> (ø)
.../isolated-cluster/imgpkginterface/client_imgpkg.go 0.00% <0.00%> (ø)
cmd/cli/plugin/isolated-cluster/test/main.go 0.00% <0.00%> (ø)
cmd/cli/plugin/cluster/set_node_pool.go 14.63% <0.00%> (ø)
cmd/cli/plugin/cluster/scale.go 17.85% <0.00%> (ø)
...in/cluster/set_machinehealthcheck_control_plane.go 21.21% <0.00%> (ø)
cmd/cli/plugin/cluster/get_node_pools.go 10.52% <0.00%> (ø)
...in/cluster/get_machinehealthcheck_control_plane.go 11.11% <0.00%> (ø)
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adduarte adduarte closed this Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vspherecsi_controller.go incorrectly attempts to reconcile TKG-system template pods
2 participants