-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Replace ValidatingWebhookConfiguration controller with watch in StoragePolicyQuota controller #792
Open
abaruni
wants to merge
1
commit into
vmware-tanzu:main
Choose a base branch
from
abaruni:topic/badnan/validatingwebhookconfiguration-watch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abaruni
force-pushed
the
topic/badnan/validatingwebhookconfiguration-watch
branch
from
November 6, 2024 17:37
66ffd9a
to
ee8d0e0
Compare
…gepolicyquota controller
abaruni
force-pushed
the
topic/badnan/validatingwebhookconfiguration-watch
branch
from
November 6, 2024 17:53
ee8d0e0
to
6305b07
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This change removes the existing
ValidatingWebhookConfiguration
controller and replaces it with watch configured on theStoragePolicyQuota
controller which watches for changes toValidatingWebhookConfigurations
.The functionality remains the same--any updates to the Webhook Server CA bundle will cause reconciliation to occur and update the CA bundle for any VM
StoragePolicyUsage
.Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: