[wip]Elerer/no row cache #2631
Open
[wip]Elerer/no row cache #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this PR a kvbc_adapter layer is created which contains various concrete implementation of the KVBC interfaces. Any component outside KVBC will access all the features of KVBC using these interfaces. We have various adaptations or comcrete implementations of these interfaces as below: 1) Replica Adapter: This adapter is the main entry point which will now encapsulate all the interfaces of kvbc 2) KV Blockchain Adapter : This adapter implement the IReader and IAdder interfaces 3) Blocks Deleter Adapter : This adapter implements the IBlocksDeleter Interface. 4) App State Adapter : This adapter implements the IAppState interface. 5) State Snapshot Adapter : This adapter implements the interfaces required for Replica State Snapshot. Replica is another concrete implementation available at a higher level. All the code which chooses the DB interface between readonly replica and replica adapter is kept in Replica class. In future all the boiler plate code which will be needed for all the different versions of blockchain, will be in the replica_adapter. And the code which is required only for the corresponding blockchain version will be kept in the corresponding blockchain specific adapter.
Moving the categorization adapters in categorization folder and adding another namespace. As these adapters are abstracted within kvbc, this change donot require any change in any other component.
In this PR following is added: 1) LatestKeys is added with the functionality of getting the latest value and version. 2) Blockchain is updated to provide the get and multiGet functionality. 3) Finally all these are added to V4BlockChain and then all these will be wired with reader adapter for V4.
teoparvanov
suggested changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
< a few sentences about what problem we want to solve with our change(e.g. description of the bug we are fixing) >
< describe automated and/or manual test scenarios >