Concord client request cmf changes #2639
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bandatarunkumar
force-pushed
the
concord_client_request_cmf_changes
branch
2 times, most recently
from
edf34e7 to
4f32319
Compare
bandatarunkumar
force-pushed
the
concord_client_request_cmf_changes
branch
from
f8314a6 to
afbc9ed
Compare
cjn
reviewed
May 25, 2022
| @@ -81,6 +82,8 @@ struct RequestConfig { | |||
| std::string span_context = ""; | |||
| bool key_exchange = false; | |||
| bool reconfiguration = false; | |||
| bftEngine::RequestType request_type = bftEngine::RequestType::RAW_MESSAGE; | |||
| std::string client_service_id = ""; | |||
There was a problem hiding this comment.
client_service_id can be moved to ClientConfig since it is not request specific but specific to a client
| @@ -104,6 +105,12 @@ class ConcordClient { | |||
|
|
|||
| std::string messageSignature(bft::client::Msg&); | |||
|
|
|||
| static void prepareConcordClientRequest(bft::client::Msg& request, | |||
There was a problem hiding this comment.
why is it a static method?Same with response
There was a problem hiding this comment.
the api needs to be called from concord_client_pool.cpp, where we might have a external_client class object, to support this case, i have made them static
bandatarunkumar
force-pushed
the
concord_client_request_cmf_changes
branch
from
afbc9ed to
0cff742
Compare
bandatarunkumar
changed the title
bandatarunkumar
force-pushed
the
concord_client_request_cmf_changes
branch
2 times, most recently
from
f9691a1 to
5d1a216
Compare
bandatarunkumar
force-pushed
the
concord_client_request_cmf_changes
branch
2 times, most recently
from
a78d228 to
a816d03
Compare
bandatarunkumar
force-pushed
the
concord_client_request_cmf_changes
branch
from
a816d03 to
04077f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving concord_client_request.proto to cmf
Testing in progress