Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug when reaching the maximal size of pre-prepare #2716

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix a bug when reaching the maximal size of pre-prepare #2716

wants to merge 2 commits into from

Conversation

yontyon
Copy link
Contributor

@yontyon yontyon commented Jun 30, 2022

  • Problem Overview
    When reaching the limit of prePrepare message size we need to break the loop where we add requests. However, a bug was found where we compare the client message to the overall size before adding the requests causing to deletion of all extra client request messages.
  • Testing Done
    CI

@yontyon yontyon requested a review from yuliasherman June 30, 2022 16:33
@yontyon yontyon requested a review from a team as a code owner June 30, 2022 16:33
yuliasherman
yuliasherman reviewed Jun 30, 2022
View reviewed changes
Copy link
Contributor

@yuliasherman yuliasherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks correct, but it has to be tested using a unit test and/or Apollo test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuliasherman yuliasherman yuliasherman left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yontyon @yuliasherman @vmwclabot