Upgrade gRPC version to 1.48.0 #2784
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shgandhi
force-pushed
the
grpc-upgrade
branch
from
86d2102 to
65de89a
Compare
shgandhi
force-pushed
the
grpc-upgrade
branch
from
65de89a to
fcad8ea
Compare
vrancurel
reviewed
Sep 9, 2022
toly-kournik
suggested changes
Sep 13, 2022
There was a problem hiding this comment.
@shgandhi , there are *.cmake files which shouldn't be installed as part of our source tree as they are either part of a cmake or of a specific library installation
shgandhi
force-pushed
the
grpc-upgrade
branch
from
fcad8ea to
5460023
Compare
Thanks for the review @toly-kournik, I have removed the redundant files in the latest rebase. |
|
Thanks for the review @vrancurel, @toly-kournik and @arc-vmware. |
shgandhi
force-pushed
the
grpc-upgrade
branch
2 times, most recently
from
9d77101 to
f1f4888
Compare
shgandhi
force-pushed
the
grpc-upgrade
branch
2 times, most recently
from
5f70adf to
90cc179
Compare
shgandhi
force-pushed
the
grpc-upgrade
branch
3 times, most recently
from
07a5692 to
e0ce91d
Compare
added 2 commits
October 4, 2022 11:17
This commit upgrades gRPC from 1.37.x to the latest release version 1.48.0. Over the past ten versions of gRPC multiple optimizations and bug fixes have been introduced. Please see https://github.com/grpc/grpc/releases for the detailed breakdown of updates from 1.38.0 to 1.48.0. This upgrade would also allow for batching of updates natively via setting the buffer hint flag for improved performance. This change updates client, TRS and UTT CMakeLists files to account for the upgrade.
FindProtobuf.cmake is already a part of standard cmake installation, hence this commit removes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the past ten versions of gRPC multiple optimizations and bug fixes have been introduced. Please see gRPC release page for the detailed breakdown of updates added from 1.38.0 to 1.48.0.
This upgrade would also allow for batching of updates natively via setting the buffer hint flag for improved performance.
This PR updates install_deps.sh, client and TRS CMakeLists files, and adds a few support cmake files to account for the upgrade.
Concord was built manually to test the change. Performance testing is being done in parallel based off of the MR.