Replicas main key rotation implementation #2948
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WildFireFlum
force-pushed
the
yf/kx-master-merge
branch
2 times, most recently
from
aad5b86 to
c769f07
Compare
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
yontyon
reviewed
Mar 2, 2023
WildFireFlum
force-pushed
the
yf/kx-master-merge
branch
from
c769f07 to
a880c00
Compare
yontyon
reviewed
Mar 5, 2023
WildFireFlum
force-pushed
the
yf/kx-master-merge
branch
9 times, most recently
from
5c62bfa to
ec67f12
Compare
…ain key rotations Extracted CryptoManager.cpp from CryptoManager.hpp
Also Fixed apollo tests which break when publishing main key updates when replicas start
Move message validation to ReplicaBase Update RO replicas key state after ST via cre (same mechanism as clients)
WildFireFlum
force-pushed
the
yf/kx-master-merge
branch
2 times, most recently
from
d6d908d to
6df5b8b
Compare
WildFireFlum
force-pushed
the
yf/kx-master-merge
branch
from
6df5b8b to
77a5e07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Overview
This PR adds support for main key rotations on demand (for example, when compromised).
The implementation uses the replica's consensus key as its main key, thus when an operator sends a consensus key rotation request, the resulting state is that both the main key and the consensus key are changed.
The behavior can be reverted back to separate the main key and consensus key (without supporting main key rotations) via the singleSignatureScheme configuration parameter.
Testing Done
Unit tests and apollo tests (local and remote)
Additional Changes
Added a convenience directory ${bft-root}/build/apollogs/ which contains links to both the logs of the latest test run and all of the previous test runs.
Also added an output file for apollo tests: /concord-bft/build/apollogs/latest/failed_cases.txt which is generated upon failure and contains the names of the tests cases which have failed.