F/gasless non wrapped tokens bis #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
any wallet to create processes Signed-off-by: emmdim <[email protected]>
from endDate allowed to be undefined
createProposal
It takes the possibility that the gasless election is succeded but the approval period is passed. So it shows passed message
This reverts commit 479664a.
creation Signed-off-by: emmdim <[email protected]>
Signed-off-by: emmdim <[email protected]>
Signed-off-by: emmdim <[email protected]>
Signed-off-by: emmdim <[email protected]>
Hide earlyExecution and vote replacement for gasless DAO's
Voting terminal for execution multisig info tab now acts as multisig voting terminal (counting approvals properly)
It checks if has already vote using the hook useGaslessHasAlreadyVote . So we can avoid this call
* updates to gasless voting sdk version that reduces significantly web3 calls Signed-off-by: emmdim <[email protected]>
Signed-off-by: emmdim <[email protected]>
(but not throw in develop :-| ) Signed-off-by: emmdim <[email protected]>
approvers Signed-off-by: emmdim <[email protected]>
For the `useProposals` hook, the returning information haven't a `vochainId`, causing a bad behavior of the dashboard proposals cards. It changes the way to know if `isGaslessProposal` to be compatible with this hook.
Vocdoni SDK and gasless voting sdk
* Implement try execution flow For gasless approval * Fix executableWithNextApproval It have not to be shown if the minTallyApprovals is 1 because the tally is not set yet * Implement approveTally methods
It was some places on the code where the GaslessPluginName whas not used properly.
Delete @vocdoni/gasless-voting-ethers also
|
test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and be sure you follow the contributions rules we do provide here
Task: APP-0000
Type of change
Checklist:
CHANGELOG.mdfile in the root folder.