Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to upstream iwd documentation page #820

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

grtcdr
Copy link
Contributor

@grtcdr grtcdr commented Nov 17, 2024

The old link redirects to the kernel's rather funny 404 page.

@grtcdr
Copy link
Contributor Author

grtcdr commented Nov 17, 2024

403 link in src/config/graphical-session/wayland.md line 61 is causing the check links step to fail. Perhaps it should be changed to https://wiki.gnome.org/Initiatives(2f)Wayland(2f)Applications.html.

Official GTK documentation also links to this (now) forbidden resource: https://docs.gtk.org/gtk3/wayland.html

@grtcdr
Copy link
Contributor Author

grtcdr commented Nov 17, 2024

Running vmdfmt -w iwd.md (or check.sh) does not affect the file, so formatting shouldn't be failing in CI.

@classabbyamp
Copy link
Member

classabbyamp commented Nov 17, 2024

I get the same diff as CI from vmdfmt, not sure what you're doing locally

The old link redirects to the kernel's rather funny 404 page and the new
link says "For most up-to-date information on network settings see the
iwd.network(5) man page shipped with IWD (source), which incorporates most
of this page's content now."
@classabbyamp
Copy link
Member

the new page says

For most up-to-date information on network settings see the iwd.network(5) man page shipped with IWD (source), which incorporates most of this page's content now.

so we should just link iwd.network(5) instead

@classabbyamp classabbyamp merged commit 1008fd6 into void-linux:master Nov 17, 2024
3 of 4 checks passed
@grtcdr
Copy link
Contributor Author

grtcdr commented Nov 17, 2024

I get the same diff as CI from vmdfmt, not sure what you're doing locally

I wouldn't know either. I cloned the freshly-created fork, ran vmdfmt as stated in CONTRIBUTING.md and it never found an issue with the formatting.

so we should just link iwd.network(5) instead

Even better :)

@classabbyamp
Copy link
Member

were you on the right branch?

@grtcdr
Copy link
Contributor Author

grtcdr commented Nov 17, 2024

Oh my, I wasn't. Sorry about that. I really need to add git branch information to my PROMPT (and avoid the web editor because it's plain confusing)

@grtcdr grtcdr deleted the patch-1 branch November 17, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants