(Try to) close suprocess file handles after we are done with it

This should fix pyinvoke#665
voidus · Mar 25, 2023 · 0cea56f · 0cea56f
1 parent e956312
commit 0cea56f
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/invoke/runners.py b/invoke/runners.py
@@ -1385,6 +1385,11 @@ def returncode(self) -> Optional[int]:
             return self.process.returncode
 
     def stop(self) -> None:
+        for fd in ['stdout', 'stderr', 'stdin']:
+            try:
+                getattr(self.process, fd).close()
+            except:
+                pass # We tried 🤷
         # If we opened a PTY for child communications, make sure to close() it,
         # otherwise long-running Invoke-using processes exhaust their file
         # descriptors eventually.