-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux - Harden mountinfo API and several related fixes #1545
Linux - Harden mountinfo API and several related fixes #1545
Conversation
…eprocessor macro shortcuts, not actual members of the type.
…th the 'dentry' class.
…rray and a count value, it will end up with an AttributeError exception
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally happy with all of this, although not sure why the function signature for one bit changed (and without that change, there's no need for version bumps that I can see). Needs a response to some of the points raised but no showstoppers at least...
@ikelos thanks for the review. All the observations were addressed |
@ikelos hold on with this as it seems there's a commit missing |
@ikelos no worries, it's all good! Turns out it was just how GitHub was displaying the changes, pretty confusing at first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, looks good, let's go for it. 5:)
In the context of #1516 and related issues, this PR addresses several issues in the mountinfo API code and its associated functions.
This PR includes:
f_dentry
andf_vfsmnt
members were incorrectly included, though they were never part of struct file. These were preprocessor macros used as shortcuts within kernel code but should not be present in the structure itself.