Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set properties dynamically (useful for lyrics, composer etc) #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xidb
Copy link

@xidb xidb commented Jan 21, 2018

Hello.
Superb lib you have here, it helped me a lot.
But it lacks ability to set custom tags, like lyrics.
So i removed all code, that was implicitly setting things like album artist or bpm and added a piece, where those things saved dynamically. It checks and skips if current iteration is not an common tag (artist, title).
I checked for .mp3, .m4a files and i can confirm that lyrics added that way are showing up in iTunes or other software (ffmpeg, mediainfo, tagscanner).
I think it will also with an issue you have where there was a question about grouping field.

@xidb
Copy link
Author

xidb commented Jan 22, 2018

I also made a support for UTF filenames.
Also i consider removing from readTagsSync all properties, that were implicitly set to string in resulting object and set them dynamically if they are found in tag's property map.
So, for example, BPM will stay implicit, as it's an integer, but i remove implicit COMPOSER and will set it dynamically.
It could be a bad idea? =)

@kbuffington
Copy link

@xidb Your PR looked like something I might be interested in as I need dynamic properties as well, but when I try and build this on OSX, I get the same errors the Travis CI build does. Did you ever do more work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants