replace undefined element by -1 in getAlbumArt URL #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids subsonic not returning an image. Tested with Airsonic server.
foobarjo
suggested changes
Oct 13, 2020
There was a problem hiding this comment.
Hi, thanks for commmiting.
By the way there are different implementations of the API and your commit won't work for all of them.
lms albumArt id: 862796b054fe3a857d7a04f0d6515d1e
ampache albumArt id: al-5b0ff64e9492ceeb78b08354b652eea7
navidrome albumArt id: 74ef6fede2cce442e8a345e122ac31e9
subsonic albumArt id: al-10378
You may want to test the variable definition with something like
if (coverArtId !== undefined){
coverArtId = -1;
}
|
this pull request can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids subsonic not returning an image. Tested with Airsonic server.