Show how to load single-spa-angularjs with babel. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since systemjs-babel only works with modules in ESM/CJS format, you need to use the src directory instead of lib directory of single-spa-angularjs in order for it to load. Additionally, the
angularlibrary isn't loaded properly by systemjs-babel since it's in global format, which isn't supported by babel.I don't recommend using systemjs-babel, generally speaking, and definitely not with old libraries that aren't in ESM format. So I wouldn't recommend merging and using this PR, as it's going down a path I don't recommend. I shared it with you anyway in case you wish to ignore that recommendation.