This repository has been archived by the owner on Sep 9, 2024. It is now read-only.
Attempt at fixing packaging and other issues #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djova-dolby
force-pushed
the
feature/try_fix_packaging
branch
4 times, most recently
from
39d551c
to
d30d097
Compare
- Fix packaging of C++SDK libraries for UE4 -> Include what is needed in the FilterPlugin.ini file -> UE4 doesn't look for per platform files like UE5, so leave them there - Change paths names back to what they were for library locations -> Not sure if this will help anything, but who knows -> This appears to working locally now. Krystian and I have been able to build on macOS platforms -> Also we have been able to package games and run them
- Enum class was trying to be logged as string directly - For some reason this compiles? But it would crash in the handler - Add proper conversion to string
- Revert path creation to account windows slash
--- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Taken-from: dependabot[bot] <[email protected]>
djova-dolby
force-pushed
the
feature/try_fix_packaging
branch
from
d30d097
to
6aaac69
Compare
- For Windows add avformat in the build cs file -> It looks like the file to be loaded from cpp module file must be in cs also - For macOS include the dvdnr lib in cpp module file -> It was in the C# build file as a runtime dep
djova-dolby
force-pushed
the
feature/try_fix_packaging
branch
from
26f70eb
to
7c13ce5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.