Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clarifying steps in section. #76

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

harpreetsahota204
Copy link

What changes are proposed in this pull request?

I have added clarifying steps to the Dataset Views section. These changes aim to make it more clear to a first-time user how to create a view in the app.

How is this patch tested? If it is not, please explain why.

Not tested. Changes only applied to a markdown cell.

@jacobmarks jacobmarks self-requested a review March 5, 2024 22:42
Copy link
Contributor

@jacobmarks jacobmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clarifications. The enumeration definitely helps. LGTM 👍!

@kaixi-wang kaixi-wang self-requested a review March 5, 2024 22:44
Copy link

@kaixi-wang kaixi-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait don't merge

Copy link

@kaixi-wang kaixi-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check the images pics match the text. Some images have been updated and they aren't what is described. For instance, the example for showing a modal:
image
(left is your version/current revision)

@harpreetsahota204
Copy link
Author

@kaixi-wang - I've updated accordingly

@brimoor
Copy link
Contributor

brimoor commented Mar 7, 2024

@harpreetsahota204 can you take one more pass over the notebook and tweak a couple things for consistency with how the notebook currently exists at https://colab.research.google.com/github/voxel51/fiftyone-examples/blob/master/examples/quickstart.ipynb? Thanks!

Here's what I'm seeing:

Images

  • the image at the end of the Automatic screenshots as you work section is missing

Cell outputs

It looks like you ran certain cells at the top of the notebook after running the rest of the notebook. This could cause confusion for users following along locally because they won't see the same thing when running the notebook in order. For example (might be incomplete):

  • In [3]: when run in order, the dataset wouldn't yet have fields like eval_tp, etc
  • In [8]: same thing (some attributes wouldn't yet exist)
  • In [12]: dataset shouldn't yet have mistakenness fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants