-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added clarifying steps in section. #76
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clarifications. The enumeration definitely helps. LGTM 👍!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait don't merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaixi-wang - I've updated accordingly |
@harpreetsahota204 can you take one more pass over the notebook and tweak a couple things for consistency with how the notebook currently exists at https://colab.research.google.com/github/voxel51/fiftyone-examples/blob/master/examples/quickstart.ipynb? Thanks! Here's what I'm seeing: Images
Cell outputsIt looks like you ran certain cells at the top of the notebook after running the rest of the notebook. This could cause confusion for users following along locally because they won't see the same thing when running the notebook in order. For example (might be incomplete):
|
What changes are proposed in this pull request?
I have added clarifying steps to the
Dataset Views
section. These changes aim to make it more clear to a first-time user how to create a view in the app.How is this patch tested? If it is not, please explain why.
Not tested. Changes only applied to a markdown cell.