Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label count panel #166

Merged
merged 17 commits into from
Nov 26, 2024
Merged

Label count panel #166

merged 17 commits into from
Nov 26, 2024

Conversation

ritch
Copy link
Contributor

@ritch ritch commented Sep 25, 2024

import fiftyone as fo
import fiftyone.zoo as foz

dataset = foz.load_zoo_dataset("quickstart-video")

# Video example
session = fo.launch_app(dataset)

frames = dataset.to_frames(sample_frames=True)
view = frames.group_by("sample_id", order_by="frame_number")

# Video-as-frames example
session.view = view

@sashankaryal sashankaryal self-requested a review September 26, 2024 21:29
@brimoor brimoor changed the title [wip] Py panel timeline example Label count panel Oct 22, 2024
@brimoor
Copy link
Contributor

brimoor commented Oct 22, 2024

@ritch I pushed an update to get video-as-frames working (added example code to the PR description for testing) 💪

Dynamic group playback works as expected when navigation is set to "video" mode. However, in "pagination" mode it looks like the label count panel is not re-rendering when the current frame is updated in VaF Looker. See the attached video for example. Can you take a look?

Can you also fix the margins on the plot? There are a few issues:

  • field selector dropdown is clipped by top of panel
  • x axis label is clipped by bottom of panel
  • both of above cause there to be a persistent scrollbar on the right
Screen.Recording.2024-10-22.at.1.13.36.AM.mov

@ritch
Copy link
Contributor Author

ritch commented Oct 22, 2024

field selector dropdown is clipped by top of panel

Fixed in voxel51/fiftyone#4956

@ritch
Copy link
Contributor Author

ritch commented Oct 22, 2024

x axis label is clipped by bottom of panel
scrollbars

Will need @imanjra to take a look at these.

@ritch
Copy link
Contributor Author

ritch commented Oct 22, 2024

However, in "pagination" mode it looks like the label count panel is not re-rendering when the current frame is updated in VaF Looker

I think the issue is that the timeline api is not implemented for this mode. Will follow up with @sashankaryal.

@ritch
Copy link
Contributor Author

ritch commented Oct 22, 2024

I pushed an update to get video-as-frames working (added example code to the PR description for testing) 💪

Awesome 🙏 !!

@ritch
Copy link
Contributor Author

ritch commented Oct 22, 2024

it looks like the label count panel is not re-rendering when the current frame is updated in VaF Looker.

The pagination UI renders an ImageLooker and the frame number is not based on the Timeline api.

plugins/label_count/__init__.py Outdated Show resolved Hide resolved
@sashankaryal sashankaryal self-requested a review November 26, 2024 22:23
Copy link

@sashankaryal sashankaryal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! need to address navigation problem in a separate PR

@ritch ritch merged commit adcdac5 into main Nov 26, 2024
@ritch ritch deleted the poc-py-panel-timeline branch November 26, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants