-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label count panel #166
Label count panel #166
Conversation
ritch
commented
Sep 25, 2024
•
edited by brimoor
Loading
edited by brimoor
@ritch I pushed an update to get video-as-frames working (added example code to the PR description for testing) 💪 Dynamic group playback works as expected when navigation is set to "video" mode. However, in "pagination" mode it looks like the label count panel is not re-rendering when the current frame is updated in VaF Looker. See the attached video for example. Can you take a look? Can you also fix the margins on the plot? There are a few issues:
Screen.Recording.2024-10-22.at.1.13.36.AM.mov |
Fixed in voxel51/fiftyone#4956 |
Will need @imanjra to take a look at these. |
I think the issue is that the timeline api is not implemented for this mode. Will follow up with @sashankaryal. |
Awesome 🙏 !! |
The pagination UI renders an ImageLooker and the frame number is not based on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! need to address navigation problem in a separate PR