Merge pull request #5179 from voxel51/bugfix/panel-cta-im-x1

minor fixes embeddings and model evaluation panels CTA
voxel51 · Nov 22, 2024 · 488cb28 · 488cb28
2 parents dac2474 + 5939efe
commit 488cb28
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 24 deletions.
diff --git a/app/packages/components/src/components/PanelCTA/index.tsx b/app/packages/components/src/components/PanelCTA/index.tsx
@@ -158,7 +158,11 @@ function TypographyOrNode(props: TypographyProps) {
   const { children, ...otherProps } = props;
 
   if (typeof children === "string") {
-    return <Typography {...otherProps}>{children}</Typography>;
+    return (
+      <Typography sx={{ textAlign: "center" }} {...otherProps}>
+        {children}
+      </Typography>
+    );
   }
 
   if (React.isValidElement(children)) {

diff --git a/app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/index.tsx b/app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/index.tsx
@@ -91,8 +91,8 @@ export default function NativeModelEvaluationView(props) {
             demoLabel="Upgrade to FiftyOne Teams to Evaluate Models"
             description="Analyze and improve models collaboratively with your team"
             docLink="https://docs.voxel51.com/user_guide/evaluation.html"
-            docCaption="Learn how to create model evaluation via code."
-            demoDocCaption="Not ready to upgrade yet? Learn how to create model evaluation via code."
+            docCaption="Learn how to evaluate models via code."
+            demoDocCaption="Not ready to upgrade yet? Learn how to evaluate models via code."
             icon="ssid_chart"
             Actions={() => {
               return (

diff --git a/app/packages/embeddings/src/Embeddings.tsx b/app/packages/embeddings/src/Embeddings.tsx
@@ -92,14 +92,18 @@ export default function Embeddings({ containerHeight, dimensions }) {
                 containerStyle={selectorStyle}
               />
             )}
-            {computeViz.isAvailable && (
-              <PlotOption
-                to={() => computeViz.prompt()}
-                title={"Compute visualization"}
-              >
-                <Add />
-              </PlotOption>
-            )}
+            <PlotOption
+              to={() => {
+                if (constants.IS_APP_MODE_FIFTYONE) {
+                  setShowCTA(true);
+                } else {
+                  computeViz.prompt();
+                }
+              }}
+              title={"Compute visualization"}
+            >
+              <Add />
+            </PlotOption>
             {!plotSelection.selectionIsExternal && (
               <PlotOption
                 to={plotSelection.clearSelection}
@@ -152,19 +156,6 @@ export default function Embeddings({ containerHeight, dimensions }) {
             )}
             <OperatorPlacements place={types.Places.EMBEDDINGS_ACTIONS} />
           </div>
-          <MuiButton
-            startIcon={<Add />}
-            onClick={() => {
-              if (constants.IS_APP_MODE_FIFTYONE) {
-                setShowCTA(true);
-              } else {
-                computeViz.prompt();
-              }
-            }}
-            variant="contained"
-          >
-            Compute Embeddings
-          </MuiButton>
         </Selectors>
         {showPlot && (
           <EmbeddingsPlot