[DRAFT] Project Map Samples #5642

minhtuev · 2025-03-25T06:25:13Z

What changes are proposed in this pull request?

Merge main branch of Project Map Samples to Develop

How is this patch tested? If it is not, please explain why.

(Details)

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

No. You can skip the rest of this section.
Yes. Give a description of this change to be included in the release
notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

App: FiftyOne application changes
Build: Build and test infrastructure changes
Core: Core fiftyone Python library changes
Documentation: FiftyOne documentation changes
Other

…_samples

* Bump vitest from 3.0.4 to 3.0.5 in /e2e-pw (#5488) Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 3.0.4 to 3.0.5. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v3.0.5/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Added factory, map backend and sequential implementation * Added unit tests --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: minhtuevo <[email protected]>

Added map_samples with multiprocessing

* initial commit * remove test file * Update fiftyone/core/map/threading.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix tests * fix conflicts --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* initial commit * refactor * remove local symnlink

* remove old count * initial commit * fixes * refactor for implementations to yield in correct order instead of relying on super class * rename variiable for consistency * split base classes to allow for finer subclassing in future * split exception and result in case map_fcn returns exception for some reason

* Enable MP for Windows

* Bug fix for the progress bar in map samples and updated map_samples type hinting

* Fixed progress bar * Fixed batch index

* Exponential backoff to timeout

coderabbitai · 2025-03-25T06:25:21Z

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (3)

WIP
DO NOT MERGE
DRAFT

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

* Exposed map_samples/update_samples and added unit tests * Removed utils/map.py

* fix test that's failing do to switching to lazy import * remove unused import

* Updated docs with map_samples and update_samples

minhtuevo and others added 30 commits February 27, 2025 01:38

Added factory, map backend and different implementation

c2da8e1

Used recommend_thread_pool_workers

04de8a3

Refactored and added unit tests

01b19e8

removed db func

41da849

Added map_samples and update_samples to view

7fd1e07

Updated unit test to use collection.map_samples and collection.update…

3780cd5

…_samples

removed core collection

052e14a

Nitpick

7009f37

Removed redundant

c084660

Added map_samples with multiprocessing

898ce8b

Updated tests

e179aeb

Added multiprocessing utils

072cbc7

Removed save param for update_samples

2be16ab

small update

8458a44

Fixed circular import issue

da5f63e

Added unit tests

72115d6

Updated default to sequential

55854fb

Refactored batcher

c53b110

Added multiprocessing tests for evaluate detections

af4cf73

Removed unused lib

2bbc767

Removed map_samples from collections

27e82bb

Updated save to False by default and added unit test

80379d4

Added empty dataset test

9b1be5b

Refactored tests

c8544d1

Merge pull request #5525 from voxel51/minh/map-samples-implementation

1f5f567

Added map_samples with multiprocessing

Refactor map_samples/update_samples

1a6be0d

* initial commit * refactor * remove local symnlink

Merge branch 'develop' into project/map-samples

6e7e5a7

minhtuev added 4 commits March 17, 2025 23:02

Enable Multiprocessing for Windows (#5578)

dcf32e3

* Enable MP for Windows

Bug fix for progress bar in map samples a (#5611)

9bee795

* Bug fix for the progress bar in map samples and updated map_samples type hinting

Bugfix for map samples progress bar (#5620)

88350bc

* Fixed progress bar * Fixed batch index

Exponenetial backoff to timeout (#5625)

4e9d40b

* Exponential backoff to timeout

minhtuev and others added 3 commits March 26, 2025 09:36

Expose map_samples to dataset collection and dataset view (#5643)

54e8d07

* Exposed map_samples/update_samples and added unit tests * Removed utils/map.py

Fix map samples batch unit test

40f88ae

* fix test that's failing do to switching to lazy import * remove unused import

Adding documentation for map_samples and update_samples (#5664)

0e6c360

* Updated docs with map_samples and update_samples

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DRAFT] Project Map Samples #5642

[DRAFT] Project Map Samples #5642

minhtuev commented Mar 25, 2025

coderabbitai bot commented Mar 25, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

[DRAFT] Project Map Samples #5642

Are you sure you want to change the base?

[DRAFT] Project Map Samples #5642

Conversation

minhtuev commented Mar 25, 2025

What changes are proposed in this pull request?

How is this patch tested? If it is not, please explain why.

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

What areas of FiftyOne does this PR affect?

coderabbitai bot commented Mar 25, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community