Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only install timesync related packages if enabled #1852

Closed
wants to merge 1 commit into from

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Mar 13, 2024

strictly speaking this shouldn't be backwards incompatible, but someone somewhere may be relying on time related packages being installed by default.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 74.53%. Comparing base (0b477ea) to head (357e2eb).

Files Patch % Lines
lib/beaker/host_prebuilt_steps.rb 58.33% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1852      +/-   ##
==========================================
+ Coverage   74.52%   74.53%   +0.01%     
==========================================
  Files          81       81              
  Lines        4506     4509       +3     
==========================================
+ Hits         3358     3361       +3     
  Misses       1148     1148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h0tw1r3 h0tw1r3 closed this Mar 13, 2024
@h0tw1r3 h0tw1r3 deleted the filter-timesync-packages branch March 13, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant