Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-37978: Add 'amazon' to repo_filename method with tests for 4.x #1857

Conversation

span786
Copy link
Contributor

@span786 span786 commented Mar 22, 2024

Added 'amazon' support in #repo_filename method in lib/beaker/host/unix/file.rb.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.94%. Comparing base (73424bd) to head (b8db4a0).

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #1857   +/-   ##
=======================================
  Coverage   74.94%   74.94%           
=======================================
  Files          82       82           
  Lines        4865     4865           
=======================================
  Hits         3646     3646           
  Misses       1219     1219           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@span786 span786 changed the title [PE-37978]: Add 'amazon' to repo_filename method with tests [PE-37978]: Add 'amazon' to repo_filename method with tests for 4.x Mar 22, 2024
@span786 span786 changed the title [PE-37978]: Add 'amazon' to repo_filename method with tests for 4.x PE-37978: Add 'amazon' to repo_filename method with tests for 4.x Mar 22, 2024
@bastelfreak
Copy link
Member

please wait until #1858 got merged, then try to cherry-pick the commit.

@span786
Copy link
Contributor Author

span786 commented Mar 27, 2024

Opened a new PR #1861 by cherry-picking the required changes in commit from master

@span786 span786 closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants