Adding a variable to allow the declaration of the next-server IP #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Mar 29, 2020
bastelfreak
reviewed
Mar 29, 2020
ekohl
requested changes
May 11, 2020
astritsinani
force-pushed
the
parameteradding
branch
from
d01d98e to
58c42f7
Compare
… used to specify the host address of the server from which the initial boot file (specified in the filename statement) is to be loaded (TFTP). Server-name is a numeric IP address on our primary DataCenter. Will be very helpful for us if this variable can be added and we can use fully the externale module:
example:
dhcpd::host { 'vh16-la':
mac => 'AC:1F:6B:41:6C:FA',
ip => 'vh16-la.vlan3',
options => { 'host-name' => 'vh16-la'},
parameters => { 'next-server' => '192.168.3.253'},
}
astritsinani
force-pushed
the
parameteradding
branch
from
58c42f7 to
618d9db
Compare
ekohl
reviewed
May 29, 2020
| define dhcp::host ( | ||
| Optional[Stdlib::IP::Address] $ip = undef, | ||
| Dhcp::Mac $mac, | ||
| String $ddns_hostname = $name, | ||
| Hash $options = {}, | ||
| Hash $parameters = {}, |
There was a problem hiding this comment.
Would this be a better suggestion?
Suggested change
| Hash $parameters = {}, | |
| Hash[String[1], Any] $parameters = {}, |
Rather than Any it could also be String[1] but I don't know if you also want to deal with Integer.
ekohl
reviewed
May 29, 2020
|
Dear @astritsinani, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the parameters variable to have next-server statement which is used to specify the host address of the server from which the initial boot file (specified in the filename statement) is to be loaded (TFTP). Server-name is a numeric IP address on our primary DataCenter. Will be very helpful for us if this variable can be added and we can use fully the externale module:
example:
dhcpd::host { 'vh16-la':
mac => 'AC:1F:6B:41:6C:FA',
ip => 'vh16-la.vlan3',
options => { 'host-name' => 'vh16-la'},
parameters => { 'next-server' => '192.168.3.253'},
}
Thanks