Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management jvm.options (ES V6 V7 < 7.7.0) #1162

Closed
wants to merge 1 commit into from
Closed

Management jvm.options (ES V6 V7 < 7.7.0) #1162

wants to merge 1 commit into from

Conversation

phaedriel
Copy link
Contributor

@phaedriel phaedriel commented Apr 23, 2022

Pull Request (PR) description

  • Add new parameter (enum) $release_type to separate differents jvm.options (some expert settings are different between 'DEB' and 'LINUX' ...etc and between v7 and v6)
  • Templates 7 are made from 7.6.2 releases
  • Templates 6 are made from 6.8.23 releases
  • Add code in 000_elasticsearch_init_spec.rb for the coverage 100%

Templates are in 2 parts

  • first part $jvm_options (-Xms, -Xmx and others custom choices)
  • second part "expert settings" : fixed values

This Pull Request (PR) fixes the following issues

Pull request acceptance prerequisites:

  • Signed the CLA (if not already signed)
  • Rebased/up-to-date with base branch
  • Tests pass
  • Updated CHANGELOG.md with patch notes (if necessary)
  • Updated CONTRIBUTORS (if attribution is requested)

@phaedriel
Copy link
Contributor Author

phaedriel commented Aug 26, 2022

I close. i do an another proposition #1168

@phaedriel phaedriel closed this Aug 26, 2022
@phaedriel phaedriel deleted the jvm_options_file branch August 27, 2022 18:53
@phaedriel phaedriel restored the jvm_options_file branch August 27, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant