(FEAT) Add simple standardized header template #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcpunk
force-pushed
the
header
branch
2 times, most recently
from
1cdb715 to
253f382
Compare
logicminds
requested changes
Jan 12, 2021
| @@ -63,6 +63,35 @@ The following sections/settings are included. | |||
| } | |||
| ``` | |||
|
|
|||
| ### EPP Templates | |||
There was a problem hiding this comment.
I would prefer to see a native puppet function that takes all these parameters. Something like
extlib::puppet_managed(String $message = 'WARNING This file is managed by puppet. Do not edit!',
String $begin_line = '#',
String $end_line = '',
Int $line_length = 70,
String $metadata_title = 'Metadata:',
Hash $metadata = {} ) >> String {
}
# process content here and break into multiple lines
Then in the template it would be
<%= extlib::puppet_managed() %>
| Int $line_length = 70, | ||
| String $metadata_title = 'Metadata:', | ||
| Hash $metadata = {} | ||
| | -%> |
There was a problem hiding this comment.
This is complex and too many tags to understand. Would prefer to have the logic in the function.
|
Dear @jcpunk, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
It seems every module has a different way of putting the This is a puppet managed file don't edit it in their templates. They are all a bit different and each one says slightly different things. This is my attempt to get something a bit more unified in place so folks can have greater consistency in their modules.