Add SELinux support for the Icinga 2 core #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbetz
force-pushed
the
enhancement/selinux
branch
from
9720327 to
da92e0b
Compare
bastelfreak
reviewed
Aug 3, 2024
| @@ -89,6 +89,13 @@ | |||
| features => [], | |||
| } | |||
|
|
|||
| # check selinux | |||
| $_selinux = if fact('os.selinux.enabled') and $facts['os']['selinux']['enabled'] and $icinga2::globals::selinux_package_name { | |||
There was a problem hiding this comment.
I think we can simplify it a bit. fact() will return the fact value, if the fact exists, or undef:
Suggested change
| $_selinux = if fact('os.selinux.enabled') and $facts['os']['selinux']['enabled'] and $icinga2::globals::selinux_package_name { | |
| $_selinux = if fact('os.selinux.enabled') == true and $icinga2::globals::selinux_package_name { |
There was a problem hiding this comment.
I did it the same way as in the icinga2 module. And the unit test on FreeBSD and Windows said it's required.
bastelfreak
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.