Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for certbot-dns-linode #363

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Add support for certbot-dns-linode #363

merged 6 commits into from
Oct 18, 2024

Conversation

justafish
Copy link
Contributor

Pull Request (PR) description

Adds support for https://certbot-dns-linode.readthedocs.io/

This Pull Request (PR) fixes the following issues

n/a

kenyon
kenyon reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, overall looks good to me.

manifests/plugin/dns_linode.pp Outdated Show resolved Hide resolved
manifests/plugin/dns_linode.pp Outdated Show resolved Hide resolved
@justafish
Copy link
Contributor Author

@kenyon thanks for the review, I've made the suggested changes 👍

@justafish justafish requested a review from kenyon October 18, 2024 16:22
@kenyon kenyon added the enhancement New feature or request label Oct 18, 2024
@kenyon kenyon merged commit 779531b into voxpupuli:master Oct 18, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyon kenyon kenyon approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justafish @kenyon