-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move documentation from README into the manifests #709
Conversation
6c26e83
to
7aa1a72
Compare
I would remove the reference section in README.md as well |
@stevenpost I'm woriking on a PR to move from params to hiera. |
done |
7fbf46c
to
eb97345
Compare
Did you use the 'strings:generate:reference' rake task to update Reference.md? |
I used the command |
The example with repo version both in readme and globals class uses 3.6. Since 5.0 is default now and only 4.4 really is an option, should we change to 4.4 and set the title to something like This applies to enterprise as well as community repos. |
Unfortunately I'm not able to run the rake task.
This is after running From what I can tell tough, it should be fine to use a different command if the result is the same. The pipeline checks if the REFERENCE.md file is up-to-date, if not, the check fails and it won't continue with rspec of beaker tests. PS: the module could use a modulesync, my PR on the CONTRIBUTING template got in and the old commands no longer work. |
Jepp, hence my thumbs up :) |
eb97345
to
b5f6935
Compare
I added a separate example for installing from enterprise, just to make it clear. Added some style fixes as well. |
|
Documentation can be more easily generated using docstrings.
b5f6935
to
cb2c4de
Compare
Revert what? I'm referring to voxpupuli/modulesync_config#881 |
Hmm, I didn't notice, someone just stepped in two days ago and released 5.0.0 ... |
Ah I see. But there is no new release of module_sync yet. |
Documentation can be more easily generated using docstrings.
This was cherry-picked from @witjoh's WIP #677.