Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move documentation from README into the manifests #709

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

stevenpost
Copy link
Contributor

Documentation can be more easily generated using docstrings.

This was cherry-picked from @witjoh's WIP #677.

@h-haaks
Copy link
Contributor

h-haaks commented Mar 20, 2024

I would remove the reference section in README.md as well

manifests/globals.pp Outdated Show resolved Hide resolved
manifests/globals.pp Outdated Show resolved Hide resolved
@h-haaks
Copy link
Contributor

h-haaks commented Mar 21, 2024

@stevenpost I'm woriking on a PR to move from params to hiera.
Could you please look at my comments so that we get this merged before I change to many classes?

@stevenpost
Copy link
Contributor Author

I would remove the reference section in README.md as well

done

@stevenpost stevenpost force-pushed the manifest_docs branch 2 times, most recently from 7fbf46c to eb97345 Compare March 21, 2024 09:40
@stevenpost stevenpost requested a review from h-haaks March 21, 2024 09:42
@h-haaks
Copy link
Contributor

h-haaks commented Mar 21, 2024

Did you use the 'strings:generate:reference' rake task to update Reference.md?

@stevenpost
Copy link
Contributor Author

Did you use the 'strings:generate:reference' rake task to update Reference.md?

I used the command puppet strings generate --format markdown instead. The rake task gives me errors, I should really look into that. I probably just need to change something on my local bundle config to include development.

@h-haaks
Copy link
Contributor

h-haaks commented Mar 21, 2024

The example with repo version both in readme and globals class uses 3.6.

Since 5.0 is default now and only 4.4 really is an option, should we change to 4.4 and set the title to something like
'Specify MongoDB repository version' ?

This applies to enterprise as well as community repos.

@stevenpost
Copy link
Contributor Author

Unfortunately I'm not able to run the rake task.

$ bundle exec rake strings:generate
/home/posts/puppet/puppet-mongodb/.vendor/ruby/3.2.0/gems/io-event-1.5.1/lib/io/event/support.rb:27: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
[error]: Missing 'redcarpet' gem for Markdown formatting. Install it with `gem install redcarpet`

This is after running bundle install with both development and release.

From what I can tell tough, it should be fine to use a different command if the result is the same. The pipeline checks if the REFERENCE.md file is up-to-date, if not, the check fails and it won't continue with rspec of beaker tests.

PS: the module could use a modulesync, my PR on the CONTRIBUTING template got in and the old commands no longer work.

@h-haaks
Copy link
Contributor

h-haaks commented Mar 21, 2024

Jepp, hence my thumbs up :)

@stevenpost
Copy link
Contributor Author

The example with repo version both in readme and globals class uses 3.6.

Since 5.0 is default now and only 4.4 really is an option, should we change to 4.4 and set the title to something like 'Specify MongoDB repository version' ?

This applies to enterprise as well as community repos.

I added a separate example for installing from enterprise, just to make it clear. Added some style fixes as well.

@h-haaks
Copy link
Contributor

h-haaks commented Mar 21, 2024

PS: the module could use a modulesync, my PR on the CONTRIBUTING template got in and the old commands no longer work.
Or we could just create a PR that reverts that change.

Documentation can be more easily generated using docstrings.
@stevenpost
Copy link
Contributor Author

PS: the module could use a modulesync, my PR on the CONTRIBUTING template got in and the old commands no longer work. Or we could just create a PR that reverts that change.

Revert what? I'm referring to voxpupuli/modulesync_config#881

@h-haaks
Copy link
Contributor

h-haaks commented Mar 21, 2024

Hmm, I didn't notice, someone just stepped in two days ago and released 5.0.0 ...

@h-haaks
Copy link
Contributor

h-haaks commented Mar 21, 2024

PS: the module could use a modulesync, my PR on the CONTRIBUTING template got in and the old commands no longer work. Or we could just create a PR that reverts that change.

Revert what? I'm referring to voxpupuli/modulesync_config#881

Ah I see. But there is no new release of module_sync yet.
It's usually pushed to all modules when released I think.

@h-haaks h-haaks merged commit b4f0d17 into voxpupuli:master Mar 21, 2024
14 checks passed
@stevenpost stevenpost deleted the manifest_docs branch March 21, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants