Move to setup_acceptance_node.pp #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjenz
approved these changes
Jan 6, 2024
ekohl
force-pushed
the
move-to-setup_acceptance_node
branch
from
5cea9f3 to
741355f
Compare
Rather than writing the setup code in Ruby, this is now written in Puppet. That works better with modulesync. It also switches from the legacy operatingsystem fact to the modern os.name fact. This is now easily detectable with puppet-lint.
ekohl
force-pushed
the
move-to-setup_acceptance_node
branch
from
741355f to
c76fea6
Compare
ekohl
commented
Jan 6, 2024
| @@ -1,13 +1,10 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| # This file is completely managed via modulesync | |||
There was a problem hiding this comment.
This was a lie. It now really is managed via modulesync.
bastelfreak
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than writing the setup code in Ruby, this is now written in Puppet. That works better with modulesync. It also switches from the legacy operatingsystem fact to the modern os.name fact. This is now easily detectable with puppet-lint.