Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#357) Add Ubuntu 22.04 LTS (Jammy Jellyfish) support #358

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

prolixalias
Copy link
Contributor

Pull Request (PR) description

add ubuntu jammy support
adjust lower limit for vcsrepo as < 5.0.0 breaks upgrades
extend regex for python_version param to accomodate d.dd (3.10) on jammy`

This Pull Request (PR) fixes the following issues

Fixes #357

@prolixalias
Copy link
Contributor Author

I may need some guidance on how to make those tests pass. Output isn't making any sense to me but I'm happy to address if someone doesn't mind giving a nudge in the right direction.

@smortex
Copy link
Member

smortex commented Jun 9, 2022

I may need some guidance on how to make those tests pass. Output isn't making any sense to me but I'm happy to address if someone doesn't mind giving a nudge in the right direction.

Looks like the unit tests failure is a regression caused by the addition of type validation in the apache module and this module passing an unexpected data type (I opened #359 to address this issue); and the acceptance tests failure is the result of a long-stranding bug being fixed in the latest release of PuppetBoard (also fixed in #359), so no failure related to these changes.

These issues put apart, we are currently lacking the tooling that allows to run the test suite on this version of Ubuntu, so for now we can't really merge it…

@gdubicki
Copy link
Contributor

These issues put apart, we are currently lacking the tooling that allows to run the test suite on this version of Ubuntu, so for now we can't really merge it…

Can't we use Ubuntu 22.04 beta image from GHA here, @smortex?

@vox-pupuli-tasks
Copy link

Dear @prolixalias, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@prolixalias
Copy link
Contributor Author

Please let me know if there's anything additional I can do to help move this one forward.

@smortex
Copy link
Member

smortex commented Jun 22, 2022

Thanks!

Support for Ubuntu Jammy was released a few hours ago, let's close and re-open this PR to trigger a new CI pipeline!

@smortex smortex closed this Jun 22, 2022
@smortex smortex reopened this Jun 22, 2022
@smortex
Copy link
Member

smortex commented Jun 22, 2022

Ah crap, we are in fact waiting for puppet packages on this version of Ubuntu which is not available ATM:
https://tickets.puppetlabs.com/browse/PA-4233

😒

@prolixalias
Copy link
Contributor Author

30JUN according to Ben... So close. Curious though, we should be able to move forward with this PR I think...? Agent itself has no bearing in this case. I'm happy to wait though, if it meets criteria I'm unaware of. Thanks for the help so far, it's much appreciated

@gdubicki gdubicki changed the title (#357) add ubuntu jammy support (#357) Add Ubuntu 22.04 LTS (Jammy Jellyfish) support Jun 23, 2022
@bastelfreak
Copy link
Member

@prolixalias the agent is required. our CI will create a docker container with ubuntu 22.04, install the puppet agent and then this puppet module to test it. this currently doesn't work because the puppet agent packages are currently missing.

@prolixalias prolixalias force-pushed the feature_extend_regex branch from cb86b07 to b36de37 Compare August 10, 2022 10:51
@prolixalias
Copy link
Contributor Author

Assuming this announcement about 22.04 is a step in the right direction. Looks like cron is going to be an issue. I'll dig into it today.

@prolixalias prolixalias force-pushed the feature_extend_regex branch from b36de37 to 6ae2bde Compare August 10, 2022 11:10
@prolixalias
Copy link
Contributor Author

I'm stumped. No matter what I've tried, cannot workaround the cron issue or even determine why cron-related output is showing. Can anyone take a look with me?

@gdubicki
Copy link
Contributor

The first error seem to be this, not cron:

  Error: Could not set 'file' on ensure: No such file or directory @ rb_sysopen - /etc/puppetlabs/puppetdb/conf.d/config.ini (file: /etc/puppetlabs/code/environments/production/modules/puppetdb/manifests/server/global.pp, line: 11)
  Error: Could not set 'file' on ensure: No such file or directory @ rb_sysopen - /etc/puppetlabs/puppetdb/conf.d/config.ini (file: /etc/puppetlabs/code/environments/production/modules/puppetdb/manifests/server/global.pp, line: 11)
  Wrapped exception:
  No such file or directory @ rb_sysopen - /etc/puppetlabs/puppetdb/conf.d/config.ini
  Error: /Stage[main]/Puppetdb::Server::Global/File[/etc/puppetlabs/puppetdb/conf.d/config.ini]/ensure: change from 'absent' to 'file' failed: Could not set 'file' on ensure: No such file or directory @ rb_sysopen - /etc/puppetlabs/puppetdb/conf.d/config.ini (file: /etc/puppetlabs/code/environments/production/modules/puppetdb/manifests/server/global.pp, line: 11)

@linuxdaemon
Copy link

What's the status of this work? Super interested in 22.04 support myself

@bastelfreak
Copy link
Member

I assume this is failing because Puppet is unable to provide PuppetDB packages for Ubuntu 22.04: https://tickets.puppetlabs.com/browse/PDB-5523

@absld
Copy link

absld commented Oct 30, 2023

Hi, are there any updates? PuppetDB packages seem to be available for Ubuntu 22.04 now.

@kenyon kenyon force-pushed the feature_extend_regex branch from 6ae2bde to a4bb1d4 Compare November 1, 2023 04:19
@kenyon kenyon force-pushed the feature_extend_regex branch from a4bb1d4 to ef46355 Compare November 1, 2023 04:26
@techsk8
Copy link

techsk8 commented Dec 7, 2023

Any news on this yet? Any particular reasons this is not merged yet?

@bastelfreak bastelfreak merged commit 78834f7 into voxpupuli:master Dec 7, 2023
14 checks passed
@bastelfreak bastelfreak added the enhancement New feature or request label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for ubuntu jammy - PR to accompany
7 participants