-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#357) Add Ubuntu 22.04 LTS (Jammy Jellyfish) support #358
Conversation
I may need some guidance on how to make those tests pass. Output isn't making any sense to me but I'm happy to address if someone doesn't mind giving a nudge in the right direction. |
Looks like the unit tests failure is a regression caused by the addition of type validation in the apache module and this module passing an unexpected data type (I opened #359 to address this issue); and the acceptance tests failure is the result of a long-stranding bug being fixed in the latest release of PuppetBoard (also fixed in #359), so no failure related to these changes. These issues put apart, we are currently lacking the tooling that allows to run the test suite on this version of Ubuntu, so for now we can't really merge it… |
Can't we use Ubuntu 22.04 beta image from GHA here, @smortex? |
Dear @prolixalias, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
1d443ae
to
cb86b07
Compare
Please let me know if there's anything additional I can do to help move this one forward. |
Thanks! Support for Ubuntu Jammy was released a few hours ago, let's close and re-open this PR to trigger a new CI pipeline! |
Ah crap, we are in fact waiting for puppet packages on this version of Ubuntu which is not available ATM: 😒 |
30JUN according to Ben... So close. Curious though, we should be able to move forward with this PR I think...? Agent itself has no bearing in this case. I'm happy to wait though, if it meets criteria I'm unaware of. Thanks for the help so far, it's much appreciated |
@prolixalias the agent is required. our CI will create a docker container with ubuntu 22.04, install the puppet agent and then this puppet module to test it. this currently doesn't work because the puppet agent packages are currently missing. |
cb86b07
to
b36de37
Compare
Assuming this announcement about 22.04 is a step in the right direction. Looks like cron is going to be an issue. I'll dig into it today. |
b36de37
to
6ae2bde
Compare
I'm stumped. No matter what I've tried, cannot workaround the cron issue or even determine why cron-related output is showing. Can anyone take a look with me? |
The first error seem to be this, not cron:
|
What's the status of this work? Super interested in 22.04 support myself |
I assume this is failing because Puppet is unable to provide PuppetDB packages for Ubuntu 22.04: https://tickets.puppetlabs.com/browse/PDB-5523 |
Hi, are there any updates? PuppetDB packages seem to be available for Ubuntu 22.04 now. |
6ae2bde
to
a4bb1d4
Compare
a4bb1d4
to
ef46355
Compare
Any news on this yet? Any particular reasons this is not merged yet? |
Pull Request (PR) description
add ubuntu jammy support
adjust lower limit for vcsrepo as < 5.0.0 breaks upgrades
extend regex for python_version param to accomodate d.dd (3.10) on jammy`
This Pull Request (PR) fixes the following issues
Fixes #357