Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for "error on subcontainer 'ia_addr' insert (-1)" messages in syslog #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gittygoo
Copy link

@ghoneycutt
Copy link
Member

@gittygoo thanks for the contribution! This is failing because the spec tests also need to be updated to match your change.

Check out https://github.com/voxpupuli/puppet-snmp/blob/master/spec/classes/snmp_init_spec.rb#L615

@ghoneycutt ghoneycutt added bug Something isn't working tests-fail labels Jun 13, 2019
@gittygoo
Copy link
Author

@ghoneycutt unfortunately i was a little bit too fast in the trigger, maybe you can help a bit extra also.
Problem is that although this does change correctly on /etc/default/snmpd it is not changing for me on /lib/systemd/system/snmpd.service where else would i need to change for it to be applied there?

@bastelfreak
Copy link
Member

hey @gittygoo . Is this change still requried? if so, could you please rebase against our latest master?

@kenyon kenyon removed the tests-fail label Dec 5, 2020
@kenyon kenyon changed the title Update 18.04.yaml fix for "error on subcontainer 'ia_addr' insert (-1)" messages in syslog Dec 5, 2020
@kenyon
Copy link
Member

kenyon commented Dec 5, 2020

This change should actually be made for all versions of Debian and Ubuntu (I have experienced this problem myself). So I've updated the patch. (This may apply to RedHat family too, but I don't use it these days, so don't know for sure.)

@kenyon
Copy link
Member

kenyon commented Dec 7, 2020

@ghoneycutt unfortunately i was a little bit too fast in the trigger, maybe you can help a bit extra also.
Problem is that although this does change correctly on /etc/default/snmpd it is not changing for me on /lib/systemd/system/snmpd.service where else would i need to change for it to be applied there?

@gittygoo for that you need to add a systemd drop-in file. https://forge.puppet.com/modules/camptocamp/systemd#drop-in-files

@elmobp
Copy link
Contributor

elmobp commented Dec 8, 2020

@ghoneycutt unfortunately i was a little bit too fast in the trigger, maybe you can help a bit extra also.
Problem is that although this does change correctly on /etc/default/snmpd it is not changing for me on /lib/systemd/system/snmpd.service where else would i need to change for it to be applied there?

@gittygoo for that you need to add a systemd drop-in file. forge.puppet.com/modules/camptocamp/systemd#drop-in-files

The systemd ones by default do not use an EnvironmentFile which is why it does not reflect as said above if you use a drop in with that it should work

@vox-pupuli-tasks
Copy link

Dear @gittygoo, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working merge-conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants