Drop Ubuntu 16.04 from PIDFILE_COMPATIBLE_IMAGES

[evgeni]

16.04 is long EOL

[ekohl]

I'm cautious with dropping things when they don't break anything else. Perhaps when CentOS 7 goes EOL we can drop the whole "compatible images" part.

[evgeni]

As for CentOS, the latest quay.io/centos/centos:centos7 seem to be working fine with systemd and pidfile (see https://github.com/voxpupuli/puppet-zabbix/actions/runs/6417557882/job/17423602472?pr=899), so I wonder if we should bump that too?

[ekohl]

Are you sure the systemd unit file still uses PIDFile there? Perhaps the root cause in Docker is fixed? I see CentOS 8 times out on spinning up the machine, so that's not a real failure due to PIDFile.

[evgeni]

[root@centos8-stream ~]# systemctl cat zabbix-server |grep PIDF
PIDFile=/var/run/zabbix/zabbix_server.pid

Pretty sure it does :)

[ekohl]

Ok, so now I wonder if CentOS 8 would also work. If so, the real cause in Docker may be fixed and the whole workaround could be dropped.

[evgeni]

How/where would I test this?
Re-running the test I linked still ends up in a timeout (https://github.com/voxpupuli/puppet-zabbix/actions/runs/6417557882/job/17425689790)
While other tests using c8s containers work fine: https://github.com/theforeman/puppet-foreman/actions/runs/6414499477/job/17415005261

[evgeni]

Amazing. The linked run was from tonight. I re-ran it, and it ends up in a timeout: https://github.com/theforeman/puppet-foreman_proxy/actions/runs/6414497675/job/17426050721

What. The. Hell.

[evgeni]

And now it passed out of all sudden. So maybe this workaround is not needed anymore.

[ekohl]

We can confirm that with other module that have the pidfile workaround. We don't appear to apply it a lot:

$ rg pidfile modules/voxpupuli/*/.sync.yml
modules/voxpupuli/puppet-zabbix/.sync.yml
15:  pidfile_workaround: CentOS,Ubuntu

modules/voxpupuli/puppet-proxysql/.sync.yml
3:  pidfile_workaround: CentOS

modules/voxpupuli/puppet-openldap/.sync.yml
3:  pidfile_workaround: CentOS

modules/voxpupuli/puppet-mongodb/.sync.yml
5:  pidfile_workaround: CentOS,Ubuntu

modules/voxpupuli/puppet-hiera/.sync.yml
2:  pidfile_workaround: CentOS

modules/voxpupuli/puppet-chrony/.sync.yml
9:  pidfile_workaround: CentOS

[ekohl]

Well, PRs are up so we'll see what CI says.

[ekohl]

Results are mixed, but certainly still needed in places.

[bastelfreak]

@evgeni can you rebase please?