Skip to content

Commit

Permalink
Remove lockfile (ilyakatz#351)
Browse files Browse the repository at this point in the history
* Remove lockfile
https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/
The intent here is to avoid the multiple dev dependencies from raising 
security issues for consumers of the gem

* Extend work by limiting files required for bundling gem

* Add missing changelog entries
  • Loading branch information
vprigent authored Nov 10, 2024
1 parent b4ee8dd commit 110ab57
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 200 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ spec/db/data_schema.rb
.ruby-version
.idea/
vendor/
Gemfile.lock
4 changes: 2 additions & 2 deletions .ruby-style.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
AllCops:
TargetRubyVersion: 2.4
TargetRubyVersion: 3.1
Include:
- "**/*.podspec"
- "**/*.jbuilder"
Expand Down Expand Up @@ -1058,4 +1058,4 @@ Style/FrozenStringLiteralComment:
Layout/SpaceBeforeFirstArg:
Enabled: false
Style/FormatStringToken:
Enabled: false
Enabled: false
7 changes: 7 additions & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

# Unreleased

- Remove committed Gemfile.lock, reduce bundled file list when running `gem install` https://github.com/ilyakatz/data-migrate/pull/351
- [Bump actionpack from 7.1.3.4 to 7.1.4.1](https://github.com/ilyakatz/data-migrate/pull/348)
- [Bump rexml from 3.3.6 to 3.3.9](https://github.com/ilyakatz/data-migrate/pull/349)
- Fix db_config_with_versions arity change and backport https://github.com/ilyakatz/data-migrate/pull/337

# 11.1.0
- Allow multiple data migration paths https://github.com/ilyakatz/data-migrate/pull/331
- Fix db:prepare:with_data task on [Rails 7.2](https://github.com/ilyakatz/data-migrate/pull/339)
Expand Down
192 changes: 0 additions & 192 deletions Gemfile.lock

This file was deleted.

11 changes: 5 additions & 6 deletions data_migrate.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ Gem::Specification.new do |s|

s.rubyforge_project = "data_migrate"

s.files = Dir["{lib,tasks}/**/*", "Changelog.md", "LICENSE", "README.md"]
s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n")
s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
s.require_paths = ["lib"]

%w[
activerecord
railties
Expand All @@ -32,10 +37,4 @@ Gem::Specification.new do |s|
s.add_development_dependency "timecop"
s.add_development_dependency "rubocop"
s.add_development_dependency "overcommit"


s.files = `git ls-files`.split("\n")
s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n")
s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
s.require_paths = ["lib"]
end

0 comments on commit 110ab57

Please sign in to comment.