Colorcoder now allows saving to custom directory locations #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to variable directory locations
…ht be able to handle greater than the default value
| @@ -64,13 +64,13 @@ def on_load(self,view): | |||
| view.settings().set('colorcode',False) | |||
| return | |||
|
|
|||
| if view.size() > set.get('max_size',10000) and not view.settings().get('forcecolorcode',False): | |||
| if view.size() > set.get('max_size',colorshemeemodifier.get_max_size()) and not view.settings().get('forcecolorcode',False): | |||
There was a problem hiding this comment.
sublime API states:
get(name, default)Returns the named setting, or default if it's not defined.
what you are doing here is essentially
set.get('max_size',set.get('max_size'))
which is redundant
please revert this and following changes of same manner
| @@ -204,9 +230,9 @@ def modify_color_scheme(l,s,read_original = False): | |||
| ) | |||
| )) | |||
|
|
|||
| newname = "/Colorcoder/%s (Colorcoded).tmTheme" % re.search("/([^/]+).tmTheme$", name).group(1) | |||
| newname = "/%s (Colorcoded).tmTheme" % re.search("/([^/]+).tmTheme$", name).group(1) | |||
There was a problem hiding this comment.
the way you populate newname will lead to problems in L#238, as color_scheme setting expects to have an sublime.load_resource compatible path eg Packages/Colorcoder/Obsidian (Colorcoded).tmTheme
i guess it would be simpler just to do
newname = "/%s/%s (Colorcoded).tmTheme" % (set.get('colorcoder_schemas_dir').strip("/\\"), re.search("/([^/]+).tmTheme$", name).group(1))
There was a problem hiding this comment.
Fixed it. It has a relative and full path now. Phew! You were completely right. I was missing something huge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified Colorcoder to allow saving custom (Colorcoded) color schemes to custom directory locations.
I also added a custom max_size so people who have beefier machines can have it automatically turn on for larger files.