Fix a bug where unmanaged objects aren't protected #318
+19
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The controller used the control-plane client to check for the existance of the instance namespace. However the instance namespaces only reside on the service clusters. This lead to an issue that PVCs and other unmanaged objects weren't actually protected in a non-converged setup.
3 tasks
Kidswiss
force-pushed
the
fix/deletion_protection_unmanaged_non_converged
branch
from
7d89785 to
059b519
Compare
Kidswiss
force-pushed
the
fix/deletion_protection_unmanaged_non_converged
branch
from
059b519 to
7432f57
Compare
Kidswiss
requested review from
a team,
TheBigLee,
wejdross and
zugao
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The controller used the control-plane client to check for the existance of the instance namespace. However the instance namespaces only reside on the service clusters.
This lead to an issue that PVCs and other unmanaged objects weren't actually protected in a non-converged setup.
This PR also contains some minor devcontainer optimizations in a separate commit.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog