Update README.md with first successful Neural Implicit Representation… #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… approach
My suggestion is to give Kudos to first successful implementation and paper for Neural Implicit Representation with periodic activation functions.
First it was created in 2018: https://scholar.google.ca/citations?view_op=view_citation&hl=en&user=eWZ79r8AAAAJ&citation_for_view=eWZ79r8AAAAJ:qjMakFHDy7sC
And code: https://github.com/Zixxy/hyperpicture
Then it was refined to paper Hypernetwork functional image representation. That paper predated and motivated authors of "Implicit Neural Rerpresentations with Periodic Activation Functions" to explore discovered phenomena in suggested PR update. Authors have reused representation discovered above and activation functions and rightfully mentioning prior work. I believe this repo should also refer to original authors as well.
Thank you.