-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support xml:lang in release notes #70
Conversation
…le only picks the first item, not picking the right language attribute set by win_sparkle_set_lang function.
Thanks! Can you please update the commit message to be correct (this doesn't "fix" anything, it implements new functionality), mention that it closes #35 and make it so that it follows the usual formatting of git commit logs? (Please see https://github.com/agis-/git-style-guide — you can use |
In addition to the comments above, this also breaks handling of appcasts without language-tagged release notes where the user code did explicitly set the language. |
ic. It is a quick solution in my case, I will spend sometime to make a sounded solution later. |
Thanks for contributing! Unfortunately there were the following style issues with your Pull Request:
Please see https://github.com/agis-/git-style-guide (you can use This message was auto-generated by https://gitcop.com |
What about doing it sooner than what I suspect means "never"? You already spent time doing the PR (appreciated!), I spent time reviewing it (instead of just closing it as broken), WinSparkle could use some quality giving back... |
Thanks for contributing! Unfortunately there were the following style issues with your Pull Request:
Please see https://github.com/agis-/git-style-guide (you can use This message was auto-generated by https://gitcop.com |
:) i spent 30 minutes to learn lambda, here is the update. |
Thanks, but unfortunately you didn't address either of the major issues: flawed language detection and the fact that it breaks feeds that don't use xml:lang. I simply can't merge this like this. Also, please don't ignore the request for proper git commit messages. It's basic code hygiene and I have hard time believing you don't see how uninformative a commit message like "change approach" is. |
Closing this PR because the author abandoned it in half-finished state. |
Before the fix, winsparkle only picks the first item, not picking the right language attribute set by win_sparkle_set_lang function.