-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/witi 148 auto approve org req #63
base: master
Are you sure you want to change the base?
Feature/witi 148 auto approve org req #63
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to review and merge b2b-organizations-graphql before we can accept this PR, but I found one issue you can address in the meantime.
react/graphql/getB2BSettings.graphql
Outdated
@@ -0,0 +1,10 @@ | |||
query GetB2BSettings { | |||
getB2BSettings { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the @context(provider: '...')
directive
|
Kudos, SonarCloud Quality Gate passed! |
My message was gone when I approved the tests... workflow fixed, you can go ahead @polishq, thanks! |
cd50bcc
to
a1774e5
Compare
a1774e5
to
dc057c0
Compare
c235eb1
to
b6d1de9
Compare
49b78d4
to
114ec37
Compare
53fee8a
to
4cc796d
Compare
What problem is this solving?
Admin for b2b settings to have auto approval of new organizations possible
How to test it?
You will need the b2b organization graphql repo to link as well for this to work properly
Go to https://witi204--whitebird.myvtex.com/admin/b2b-organizations/organizations/#/settings and the fields should be populated with the settings from masterdata
If auto approval is set to yes, go to https://witi204--whitebird.myvtex.com/account#/organization with an account without an organization and sign up. It should auto approval the organization for you
Screenshots or example usage:
Describe alternatives you've considered, if any.
I was thinking of instead of updating the request status to approved if auto approve is checked off, that we just create the organization instead.
Let me know if that makes more sense