Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/witi 148 auto approve org req #63

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

paulosyatt
Copy link

What problem is this solving?

Admin for b2b settings to have auto approval of new organizations possible

How to test it?

You will need the b2b organization graphql repo to link as well for this to work properly

Go to https://witi204--whitebird.myvtex.com/admin/b2b-organizations/organizations/#/settings and the fields should be populated with the settings from masterdata

If auto approval is set to yes, go to https://witi204--whitebird.myvtex.com/account#/organization with an account without an organization and sign up. It should auto approval the organization for you

Screenshots or example usage:

Screen Shot 2022-07-22 at 11 55 34 AM

Describe alternatives you've considered, if any.

I was thinking of instead of updating the request status to approved if auto approve is checked off, that we just create the organization instead.

Let me know if that makes more sense

@paulosyatt paulosyatt requested a review from a team as a code owner August 3, 2022 17:30
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Aug 3, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link
Contributor

@polishq polishq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to review and merge b2b-organizations-graphql before we can accept this PR, but I found one issue you can address in the meantime.

@@ -0,0 +1,10 @@
query GetB2BSettings {
getB2BSettings {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the @context(provider: '...') directive

@github-actions
Copy link

github-actions bot commented Aug 12, 2022

Fails
🚫

We follow keepachangelog standards.

Please, change the file CHANGELOG.md adding a small summary of your changes under the [Unreleased] section. Example:

 ## [Unreleased]

+ ### Fixed
+ - Issue with image sizing in the SKU Selector.

Possible types of changes:

  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.
Warnings
⚠️

Looks like this PR is too large [:bulb: smaller PRs are easy to review and approve]

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 681, PR deletions = 9

Generated by 🚫 dangerJS against 98ad78f

react/admin/OrganizationsTable.tsx Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
11.3% 11.3% Duplication

thyarles
thyarles previously approved these changes Aug 13, 2022
@thyarles
Copy link
Contributor

My message was gone when I approved the tests... workflow fixed, you can go ahead @polishq, thanks!

@thyarles thyarles self-requested a review August 13, 2022 01:43
@thyarles thyarles dismissed their stale review August 13, 2022 01:44

Just fixed the workflow.

@thyarles thyarles removed their request for review August 13, 2022 01:44
paulosyatt pushed a commit to syatt-io/b2b-organizations that referenced this pull request Aug 22, 2022
@paulosyatt paulosyatt requested review from polishq and thyarles and removed request for polishq January 26, 2023 20:51
@paulosyatt paulosyatt force-pushed the feature/WITI-148-auto-approve-org-req branch 3 times, most recently from cd50bcc to a1774e5 Compare January 31, 2023 15:19
@paulosyatt paulosyatt closed this Jan 31, 2023
@paulosyatt paulosyatt force-pushed the feature/WITI-148-auto-approve-org-req branch from a1774e5 to dc057c0 Compare January 31, 2023 15:21
@paulosyatt paulosyatt reopened this Jan 31, 2023
@paulosyatt paulosyatt force-pushed the feature/WITI-148-auto-approve-org-req branch from c235eb1 to b6d1de9 Compare January 31, 2023 15:35
@paulosyatt paulosyatt requested review from polishq and removed request for thyarles January 31, 2023 16:06
@paulosyatt paulosyatt force-pushed the feature/WITI-148-auto-approve-org-req branch from 49b78d4 to 114ec37 Compare January 31, 2023 16:09
@paulosyatt paulosyatt force-pushed the feature/WITI-148-auto-approve-org-req branch from 53fee8a to 4cc796d Compare February 1, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants