Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip graphql query if parameter is null #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

enzomerca
Copy link
Contributor

What problem is this solving?

We were observing the error Variable "$email" of required type "String!" was not provided on the logs and this PR avoid calls that were causing the error.
Now the getQuoteEnabledForUser query is skipped if the userEmail parameter is empty (resulting in the same behaviour)

@enzomerca enzomerca requested a review from a team November 22, 2024 17:04
Copy link

vtex-io-ci-cd bot commented Nov 22, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Nov 22, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 3, PR deletions = 0

Generated by 🚫 dangerJS against 9bea1cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant