Feat/new splitting quote #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
| @@ -5,6 +5,14 @@ | |||
| "admin/b2b-quotes.settings.saveSettings.failure": "Неуспешно запазване на настройките", | |||
| "admin/b2b-quotes.settings.saveSettings.success": "Настройките са запазени успешно", | |||
| "admin/b2b-quotes.settings.cartLifeSpan.label": "Период на изтичане по подразбиране (в дни) за оферти и запазени колички", | |||
| "admin/b2b-quotes.settings.saveSettings.management.quotes.experiration.data": "Expiration Period for Quotes and Saved Carts", | |||
There was a problem hiding this comment.
There's a typo in the property name. It is written experiration and should be expiration. The same issue is present in the messages in other languages. Also, this property text is in English in all languages and not translated.
| <Box as="section" csx={{ paddingBottom: 5 }}> | ||
| <Box> | ||
| <h3 style={{ fontSize: '1rem', fontWeight: 600 }}> | ||
| Expiration Period for Quotes and Saved Carts |
There was a problem hiding this comment.
This section has a hardcoded text instead of a FormattedMessage. Why?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
Add new splitting quote configuration to settings UI
How to test it?
[Workspace](Link goes here!)
Screenshots or example usage:
Describe alternatives you've considered, if any.
Related to / Depends on
How does this PR make you feel? 🔗
![](put .gif link here - can be found under "advanced" on giphy)