Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/skeleton to drawer #82

Merged
merged 16 commits into from
Nov 14, 2024
Merged

Feat/skeleton to drawer #82

merged 16 commits into from
Nov 14, 2024

Conversation

iago1501
Copy link
Contributor

@iago1501 iago1501 commented Nov 13, 2024

What problem is this solving?

We are improving INP in a drawer when opening the menu on mobile devices adding a skeleton when opening the drawer to reduce the visual interaction of the user. Before, the drawer was only opened when all menu items were loaded

How to test it?

To test it you need to open your browser and change to mobile devices.

After that, you will open the performance tab and add some throttling (Network: slow 4G and CPU: 6x throttling), it's important to add those values because the analysis on mobile devices is made considering medium or slow devices for non-heavy users

image

Before

image

image

After

image

Gravacao.de.Tela.2024-11-13.as.10.01.07.mov

How does this PR make you feel? 🔗

OBS: Sorry for the mess in the commits 😭

@iago1501 iago1501 added the enhancement New feature or request label Nov 13, 2024
@iago1501 iago1501 self-assigned this Nov 13, 2024
@iago1501 iago1501 requested a review from a team as a code owner November 13, 2024 17:28
@iago1501 iago1501 requested review from gabpaladino, vsseixaso and RodrigoTadeuF and removed request for a team November 13, 2024 17:28
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 13, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Nov 13, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@iago1501 iago1501 requested review from vmourac-vtex and removed request for RodrigoTadeuF November 13, 2024 17:37
Copy link

@vsseixaso vsseixaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Use squash and merge for this PR 😅

@iago1501 iago1501 merged commit e676ea3 into master Nov 14, 2024
10 checks passed
@iago1501 iago1501 deleted the feat/skeleton-to-drawer branch November 14, 2024 14:47
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 14, 2024

Your PR has been merged! App is being published. 🚀
Version 0.18.0 → 0.18.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants