-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/skeleton to drawer #82
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Use squash and merge for this PR 😅
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
We are improving INP in a drawer when opening the menu on mobile devices adding a skeleton when opening the drawer to reduce the visual interaction of the user. Before, the drawer was only opened when all menu items were loaded
How to test it?
To test it you need to open your browser and change to mobile devices.
After that, you will open the performance tab and add some throttling (Network: slow 4G and CPU: 6x throttling), it's important to add those values because the analysis on mobile devices is made considering medium or slow devices for non-heavy users
Before
After
Gravacao.de.Tela.2024-11-13.as.10.01.07.mov
How does this PR make you feel? 🔗
OBS: Sorry for the mess in the commits 😭