Merge pull request #66 from vtex-apps/fix/icon-id-warning

Fix iconId DOM warning from Link
vtex-apps · Sep 4, 2019 · 7a1d190 · 7a1d190
2 parents dcbf745 + fae7787
commit 7a1d190
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+### Fixed
+
+- Fix iconId DOM warning from Link
+
 ## [2.18.3] - 2019-08-30
 
 ## [2.18.2] - 2019-08-29

diff --git a/react/components/StyledLink.tsx b/react/components/StyledLink.tsx
@@ -1,9 +1,10 @@
 import classNames from 'classnames'
 import React, { FunctionComponent, useContext } from 'react'
 import { Link } from 'vtex.render-runtime'
+import { Icon } from 'vtex.store-icons'
+
 import LevelContext from './LevelContext'
 import MenuContext from './MenuContext'
-import { Icon } from 'vtex.store-icons'
 
 import styles from './StyledLink.css'
 
@@ -27,6 +28,7 @@ const StyledLink: FunctionComponent<StyledLinkProps> = props => {
     disabled,
     to,
     children,
+    iconId,
     iconProps,
     iconPosition,
     treePath,
@@ -97,6 +99,7 @@ export interface StyledLinkProps extends LinkProps {
   disabled?: boolean
   accordion?: boolean
   treePath?: string
+  iconId?: string,
   iconProps?: IconProps
   iconPosition?: 'left' | 'right'
 }