Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anonymousId query argument for A/B testing #647

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Conversation

rodorgas
Copy link
Contributor

@rodorgas rodorgas commented Dec 5, 2023

What problem is this solving?

We need to integrate A/B testing via Osiris. So we need to include the argument anonymousId on sponsoredProducts query.

How to test it?

After searching for a sponsored item, the anoymousId should be sent. This can be verified by inspecting the payload in vtex.search-resolver.

Screenshots or example usage:

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

Copy link
Contributor

vtex-io-ci-cd bot commented Dec 5, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Dec 5, 2023

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@rodorgas rodorgas marked this pull request as ready for review December 7, 2023 12:38
@rodorgas rodorgas requested a review from a team as a code owner December 7, 2023 12:38
@rodorgas rodorgas requested review from gvc, lariciamota, RodrigoTadeuF and hcaula and removed request for a team December 7, 2023 12:38
@rodorgas rodorgas requested a review from a team as a code owner December 8, 2023 18:56
@rodorgas rodorgas merged commit d7b1720 into master Dec 8, 2023
1 of 4 checks passed
@rodorgas rodorgas deleted the feat/ab-testing branch December 8, 2023 18:57
Copy link
Contributor

vtex-io-ci-cd bot commented Dec 8, 2023

Your PR has been merged! App is being published. 🚀
Version 3.128.2 → 3.129.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants